From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758582AbcBXWiq (ORCPT ); Wed, 24 Feb 2016 17:38:46 -0500 Received: from mail-by2on0077.outbound.protection.outlook.com ([207.46.100.77]:16128 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758422AbcBXWin (ORCPT ); Wed, 24 Feb 2016 17:38:43 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; ettus.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;ettus.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=opensource.altera.com; Date: Wed, 24 Feb 2016 16:36:28 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Rob Herring CC: Pantelis Antoniou , Frank Rowand , Grant Likely , , , Moritz Fischer , Pantelis Antoniou , Alan Tull , Dinh Nguyen Subject: Re: [PATCH 1/1] of/overlay: of overlay callbacks In-Reply-To: <20160222025517.GS15973@rob-hp-laptop> Message-ID: References: <1455730885-1514-1-git-send-email-atull@opensource.altera.com> <1455730885-1514-2-git-send-email-atull@opensource.altera.com> <20160222025517.GS15973@rob-hp-laptop> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR07CA0020.namprd07.prod.outlook.com (25.162.170.158) To BY1PR03MB1514.namprd03.prod.outlook.com (25.162.210.148) X-MS-Office365-Filtering-Correlation-Id: 15c7be94-3d71-40b3-9e8b-08d33d6b3cca X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1514;2:3SOQaArBZ7JL9S5Z6LQUVvSXncm7W8nVxK8Pcljm++QLCQjN2idv0edDHEoWveZHJ7mPWpRqu5tAXwQGbP1Ah6ojuH/c71zw9+KO1V040h7TjwuJPo2xzui9NXY5jiiwcTiVBSL8Cudg+nevqy6EjUqYcAJ+WeybqUJH0C3eS6zGu2lxommsH6XUqbkzXJTV;3:dPQEy6JcqljCIoR1F0zmQNC1yyCjwViTdMj8dxK8eFfS7elIzdrtX1B1RulXjHKH/YjgEJfanavo1f7MPJH5zfGaT2QQW28FjuAEdAL9Ft6sJFabpr/q2nZUPJo4yI8J;25:nLr2Zmnx7hBB2OQ3t9PQn91lWGOQBq57FhUUQiQ1gK9296yN1PG3F+iTgUOBFe4TUHFHLV8St8+5gN0s1ooZvWwWxyLkIIAV2FKrocQiRF0zUPM2pbCZfYJ6mqraqe6xQ2EC3wq+P6+xdYPNq3gJmKCxNUipRy9d7Dc9bVpBorvmH1q0r3pgQHXUb387NRmx/25qBaMYO8ARU3KWwcrH5tEaodMPtbjWI3iePTiu0Tul4scn2TGEBPj2E4cL80GmJOESGq5SOpLj6S7ECn9XMfukGyzgCNT3M9AT5vbEHt8MzLv73cfegMHuS1lmQbFue9AECCmAPmiYtr9lBm3qAw==;20:6xUCr+pSV3Gou4rQIUK7HdEOiK4a6GC9RnvT+O5RKu1uuMP9IkERATJKDiTDCb+QE2bQHBlD235XdHy9gktOs7OsTbeInjaTMMUr3mLebv0zCPvpJTTNhgSBboZu50glpB6oH+EP+o62NApqTpD1VhM0xATgryCsVQ59r3AETec= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1514; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY1PR03MB1514;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1514;BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(13015025)(13023025)(5005006)(13018025)(13024025)(8121501046)(3002001)(10201501046);SRVR:BLUPR03MB034;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB034; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1514;4:zIJ6vIjXure9qciQBqjqUxo4Oe+RHOJFZ1gKWLJXjr/iRI72kzwEazprd9ftIZ7B7/24oS1WHKPo1F5lQpo+v4SuzRkxsM8ZEBD5SkoGQKTBYbHafjZSbrsjMGn4qHTOK8P9LH8qkrUZg5IVXidWK9NcF4uT26F2M7S3OaujGRILWIVNht3coze783JApuituSRp/XUochc1XGYqfqov9pSkWIwwYTtaE2Y6moaxCINwg2lHL/BypX1XSL8qnHZ3e9JNQwiUh8RyKUFVSLc5kdgYhA5W6WtD87OAd2txiZZpJFGdbuzFfc2Tg/gvTZl+9CdkrFmeBW9JDj/Wtz+fT3vPHEsFwDc8sXeDLk64EuStFSOpxkMLcTygKCbKD/DW X-Forefront-PRVS: 08626BE3A5 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(87976001)(42186005)(50986999)(3846002)(54356999)(76176999)(4326007)(189998001)(110136002)(107886002)(4001430100002)(5004730100002)(5008740100001)(53416004)(47776003)(586003)(86152002)(40100003)(33716001)(86362001)(2906002)(5001960100002)(6116002)(50466002)(83506001)(23726003)(4001350100001)(46406003)(122386002)(77096005)(5890100001)(1096002)(66066001)(2950100001)(92566002)(5005980100003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1514;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1514;23:eVmyWqxfiy3MQPXCgD9QJXq7U6RoKc25w9PeQfXBp?= =?us-ascii?Q?AE8ECSxGRKkh31gu5C2u8M5MxOoGEWYVNusszEE0ctTTBTWtNTm00/OBzTVq?= =?us-ascii?Q?TSgQ89+1r9DQSba8USDJath9dMJRyrdEa5dR8980YFHu5nyAMmwskfwiqnlE?= =?us-ascii?Q?Ckbtq1yOYmT9c/KSLfxb+X9lTmBIRsby857ncSps8kddPIIxgRNbckohlsLQ?= =?us-ascii?Q?+ps0C/IeDJ/8G8LqYK6CX9veNmNb+EvHVO/SkJTIZEwgGeN7KMZa+3P0pVBT?= =?us-ascii?Q?yBOYhiIr6hyZb3NXFmOqPODM29hRc3cpBNwU8dKUu1Na1FaYOSlI+WxvfY2Y?= =?us-ascii?Q?g0MFPt5odvmUFNjPU7aPeodvzf5Lf3urawf8CnE1njT3/SZu4Ty5gSpxgAHU?= =?us-ascii?Q?BiC5jV0VZ5SfjVHMkpvDcwg+UzbdQ70EG49DCEFJ2IDSCGVepyC+skqJhnOa?= =?us-ascii?Q?Dt7EA7YZVzlajYYd5WVaZSjCqEDhbDglzZlv2KI80eZsUaXe3yh62Ca1K1Am?= =?us-ascii?Q?TXntPBhfWbVC7Iq4zOC3QyQL8Fp8dpka6MuudcvcTeVTGQuSB/9hD0o2+bHS?= =?us-ascii?Q?lmoBF+0WSD62n4myAbb6tUszKt+2iGbq6UttodxUTpI1Q2a6XtUnPjAGgsMP?= =?us-ascii?Q?OB3h2s3vOSmf297gPo3/bcQY7RXg1CyG82FrAYp+vmGafRItbCgU2AXPoEL6?= =?us-ascii?Q?LeieqhqeNNaUQq7k7Jqq02ua6nOn4YxsSekuGLGOqp3C8WCBPbGyw0nnBxYd?= =?us-ascii?Q?2HDexhxAm7MzC84UnI2IklUwC8gZcV80SHF+y/JlAJ1v+NIRjRgM776c73ij?= =?us-ascii?Q?Jivz/l+sT9LTHCXdYcZZPQHdLK1Ih+OiDJYA99UeQcKhuS4dUw5piTC4ZX5o?= =?us-ascii?Q?Bk3EZohJyu1nzaBX5yPBJU2Va/jIa5Mfn9Allx0iJzkHjCW0pWpQYFjckxcf?= =?us-ascii?Q?DyRaJzrjlVz0gFbRUz9SP5xBPOlpFy4U8Dfs1MBfENExAX7bfNMF7BiKNHJv?= =?us-ascii?Q?8cRfv/mzsda6DwbR1w40Ak5u7HsbNKpYxkibIiR3QqzlVsr65GlTiTcytcku?= =?us-ascii?Q?m5xVfez2q2l6Y3XXqlCB8qkP+JE?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1514;5:RpmAv/uTc9yqaxegRp9+agS09qyhAr5UrixSavZDG0/0AxBycGyRSRBP90C3t/ooF/k7HHGRqUZkoUK/1ko9s//upSOWWuQKFe97LSxzhbaZN9/FeDqjiC5gFb6n8YLFryoo/IG+I98LrRwwEJFBZA==;24:vFBVzG8YYG+N2sOXrN8cskl8YU+jg8DrJAp8yqKTrNHkNGH006Hf7WGf7lUixqjd7ATSBEzJQskNINV9YR5x/PRO7qZjF4TVOsKwglI6API=;20:hmwFCzv02al+zyhtVps37mH4HzUFdEDx5P/vKHhhef+ydihsD8f4jfmg3ZNdlolW7t8M1NA88m5diINal7u1lbMI5Tr+DrZaeczONrvNfjLsWNgztFWIdZr+JrzdNHIuxYYu3j4BXcTgyPLmPFNw8J4xbKrsstxvhhP7lOzReX8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1514 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD036.protection.gbl X-Forefront-Antispam-Report: CPI:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(23726003)(92566002)(83506001)(6116002)(50466002)(77096005)(106466001)(5890100001)(33716001)(86362001)(46406003)(85426001)(2950100001)(40100003)(122386002)(4001350100001)(189998001)(76176999)(11100500001)(54356999)(6806005)(1220700001)(1096002)(21840400001)(105606002)(107886002)(5001960100002)(110136002)(50986999)(3846002)(87936001)(3720700001)(53416004)(956001)(16796002)(2906002)(4326007)(86152002)(5008740100001)(47776003)(5004730100002)(586003)(4001430100002)(66066001)(7099028)(5005980100003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB034;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD036;1:sbKjha/dRUZhFgwLrNvZ3Vh+tedq8BzhKmXU6XV0hsgh69iSYIX7cB4cVOIYWbEXrONkks+gqXF3M6nHxBgqP53iynamHEgMZFTo2T0MeBHlzqEgXQbIF8Nx8wlIfIbHPK3CGzVWxFwngbUR7PcZ6GZ7GJJQYjecy79qddMWymZPK8gSlh25gxleyZ1JdQHQz2ho8b0JgE1PX1w5kPqvxRL/3hIErMl75LEC6vJ0Xwkq7gCskE7Ap2IGpp9U6JVKzWabgVHt6ued7LBzioqkx0/2a+dfeXCMMP74ANpWcVqAo+Z4YXoF+uTOf/yJbMMX76ZRPv1QL47LLGCDWRbAVVYokuhnpAxxEC/P+pvDIsA36rd0v04s5TVWmSBElJzCLPR6EHPzklVDY7EbBTjmCuhJHeFDHSgV4rqVtgyXEMtHEvRhCGice7MtnKraoQEQ9MQq1CjnDXMT96mN5pdVdg== X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB034;2:mPGCqLGqbIfobvIlgHA5boReTvx29pApqc7ExfI05KmnEwC7m1gNb1EagSmkpsAwxdEX47K8MtVvE9Ma7moDdpFkiFBoHJvytuFPbeTCOhO8lIHcQl+kYhPwO3iT0XKYb9ZArk4RzjUNh1CjgZS03vpEN2RLZ/+xj6DE9b24txvtgX4Vazg4gC9eDwgsr5do;3:ImE7T6itiLD9bYYYhc3Xa4D9xPeU+AZfb8E/SQ1cAFXaqZ57HO3JGj7r1HOHlaavxGbq6EMvP13ghcT0ch62i5xJB8v5JOeMbsy3MBD+uMMPhjRvxyT8LReCrXWoBUvTgCc1SM0fMQGDgBf8FXgqapsiyKloyoGwKpr+yStNu8wJ3H1zduw8kxoOy2wHaokq1nV84SMvzXZ1jn2M+WwSTw==;25:TkCVFZonkGgaCCRMYQH+1nYniukd/rSlopmxnGpM6I77nH82k9Oq1aLd3XSX8X/OqrQDY710XTxsvm7dWHwpXonXazloAxw7YhbKwx/yNKfAWy5gWn7YX9bajQoVAmfVCZh9zCguBza9mgUpO2CPRqL1zIaIvpAurw/1N292mbwndilnJQ/bXAtnUv1QHpPyjwfAf26PYlntzwCpOA8zy/6GLRtu9FBGjxcraHVBQs8rLEdA/q+ymavYMt6HeZdsUjc8CS6yNE/rsWQJbSB1xNLd3r0whK1bpZI8NTYegE948T31NtkwX98mIlI5RMpVSGUEczGihP8qtq8CbmCu8g==;20:kfZkX46JteiecO8xSA5FJEHAjSttqCUYiOaLndGaE1+KW7aTsE8voUX0PlAMrqbVBc9D7zKxHC7aWJKuGdUguIXKCEI84bqw0ZWVe7wpJHHf0laHqHIQW2ishHjy+7PF5oueYuUHu+xDc7rOQaLGJMlQ4OeYYjxnjZvF1TY88Y4= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BLUPR03MB034; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB034;4:xsmx8HAQKYup7jUqK5a53T5+VnFgd58G+mlCnoFGDryrxwddRUucRFWkyCrAz4+oEZDfgKSmwBClTzn6xGXcktmm08eAP5W7tBRbxHpyxM7Nc/Sk01eqXeDTIah8x78LBT53pmOAsyZGMyfApBPEbW5n7TOBT/M9bxGrnZJ3EimrkASNh2u/fjxPjlXmqrMv0stJZegMx86BZCo3/GwFKb2pJ2sUNDr00f1rd5bk6r49jD71eT01FAUYQMLt4zMwLAho6xuPV0G/ikgQxMx/bUvWKynESPz4wIAVO+XzDsaJMic/2LHPrj71JQOfzoXLLGyowwOImZfkV4MzS+ZT4Ml7vpI1tHfjRCj8EUZWgVkLVbV70AHTUPAyN2SkSva9Gc/Ua1TQbXX4AA+AtzrSpjLRDR3Bh24siyP4prbd/jxCxMRoHDHJFqWKuNegFKBit+09ud4aQp39Xvj++3BPzA== X-Forefront-PRVS: 08626BE3A5 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB034;23:R8HS5ovQS+xII+y4no6m1fnqRU6hmXFvEuqTwQ/b8i?= =?us-ascii?Q?ApFEY7ZaAjBmKASRwdKuEwiqAsfhdKTfZIC4TUkf2Ts9Nurtoxaejx1KT5co?= =?us-ascii?Q?c+hYkAj5/O1g9r0NjoEdKyQ0gTFRps7JW+1XDflwcXk/rsO9Scv4oGkFykEE?= =?us-ascii?Q?1D/iKmvn2vb2C2rXWNfFJS308HriZ6Ct1CMtaPF1/LaF8krtonpQIQ5eT23x?= =?us-ascii?Q?yJh7DpUbw5QXQ+0bHe+rADvlXKNOAHueHvGOCb566rh50lSr+TM7B/A/3ffZ?= =?us-ascii?Q?ZjJrRYttbNEXDfhLKulO0TaO5Lp40qDW26EDsLi9ZWZ+BpNdknybzJ4edgZG?= =?us-ascii?Q?5/CAiMVnQYOZbePMOtqKFUiwHeYex0om0i4ZoTSQgLMQl9zIyUtEVlAO1Zgc?= =?us-ascii?Q?6p0hD/dhsxNcP6Rtw5rBIt8JYQWE9JSDDtN9WAYVwbL08JCeQHkjZZTxHIeg?= =?us-ascii?Q?F5UaYLvzt/1v0eiYgJmUp7tAQ5zjC2Wz6I9rXszghD6h4Fqs7M0LgtFaK1gJ?= =?us-ascii?Q?qWfrVlDv3vHkee4SEjLWfXL2utTqxXeGHsJRAIF9bypQqbmZefxfOu/AR0qE?= =?us-ascii?Q?KESothChlIBORcF0tI/5IqyVR7IvogknzKOQZNGhcCGVcOmZ1ThJD20TYDB3?= =?us-ascii?Q?XfCPyDskJraw2O0JDhNQunRkD3GzHjVETV/6cIWAlU1dbOuq0cqgg+2FtTVA?= =?us-ascii?Q?iD4cA5aC+OZ2rrS7F+6LpTN1bn2v81i82wzRDfCqnS1NWZ6eiP8usSwaRcgG?= =?us-ascii?Q?6Y69x1pnIm5fyAU+ygiCrNTT3XkM08DQlUzHy0thXkadQ/7g2P5hrkwuunxl?= =?us-ascii?Q?FVwBcdFfQLiP70hBCCRNuu55U412vJU5t7kAiGnsNRO9LPLBWUEZ+5empy58?= =?us-ascii?Q?UqHw3JRnJkJIgYhxx0kK2F9c9fG00PNr1AAhfKuzyCN/IqPwgML3hS0KjRHi?= =?us-ascii?Q?Ji2lfsgWV28mQRuH/PY+DY6ZW32/k5VOTOwxt0zUREkLh1ThK+eFnqpKyHwT?= =?us-ascii?Q?X/slmAVCMhOJx0HsQ6opBoRQ+uVmXSmO4HndHHaSfi6ZbJWuevZYB3rSBYs0?= =?us-ascii?Q?tYkOVTM8xm5MdyMJ0U2Y+xnSa0nFhvaoL15yloTlG+DjDrrG4hsx+cOi6jNR?= =?us-ascii?Q?gB9PMveimYWhn+jTb8gqUxijjg2ArNDVbuf61B3kmiLpMroTTxpqv/QxCpgQ?= =?us-ascii?Q?OwxbG8gpEh7KWLPrHJtstqsG5GfkGXc4SyYNT9Omg8I2XoSNa5Aw8J0lWh5+?= =?us-ascii?Q?L63snT+M3bbPCjavOb2rfm6RQM7J4XapwXx61HPAi3qEaG3dRjf3kiVkWW/b?= =?us-ascii?Q?lDmMparniCMsWyjZBe4xanq0kjYT0yr0kdzs/uFopcHUry5L5fQmii2dmoSx?= =?us-ascii?Q?upeFQIDDy94idBTRyn1PwoXv4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB034;5:MdAALVHDZXxA0MJ/Ly+AtSwwQ4VSJPW1Ctiy3leN6Icp49ktBr8i1GJNTXu8k1XoJSv2Sy9Q93SmoFjCIUezp7a3LqPdAlGCI/ceg7ql+2pJSdhe343RS8RZdbWivL/SJ68j9v2HAZyViG3ZjCuejA==;24:faPTz571j/soyrqmLtM0HPdbe09Cvr6UiCZYdLg8GCq4dEluuUCWxx3ULMBtholgFcZQSwH6dPbueXdoHhnN18tSoq0Rax55SRxqFYckI7s=;20:MAFEDv0XtgcIhJjphubO/WA+KjFoX6oPVK+0u7M825OpCAjVgevdxEnSYe5U+HTrv7cxF350OYt0BB46CZ21htka1pKg8h38R/gt5ehLvYbS3C1vwOTCLuj2ZG5eVRT10iGl5nhxa5YDjG3w7S9uCOfx1gXDfTwJmacZh9RJve4= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2016 22:38:37.7894 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB034 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Feb 2016, Rob Herring wrote: > On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote: > > Add overlay callback functionality. > > > > When DT overlays are being added, some drivers/subsystems > > will want to know about the changes before they go into the > > live tree. Similarly there is a need for post-remove > > callbacks. > > > > Each handler is registered with a of_device_id. When > > an overlay target matches a handler's id, the handler > > gets called. > > > > The following 4 cases are handled: pre-apply, post-apply, > > pre-remove, and post-remove. > > So I know I suggested maybe not using notifiers, but this ends up just > looking like notifiers, so we might as well use them unless we somehow > change the flow. You would just need to add pre-apply and pre-remove > in of_attach_node and of_detach_node, right? Just sent out a patch. Nobody calls of_attach_node or of_detach_node so I had to add the notifiers elsewhere. For overlays, I wanted to add a pointer to the overlay fragment since pre-apply notifiers won't otherwise have that information (unlike post-apply or pre-remove notifiers where the overlay has already made it into the live tree). That complicated the implementation a bit further. Alan > > Rob >