From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754741AbcCEGn5 (ORCPT ); Sat, 5 Mar 2016 01:43:57 -0500 Received: from mail-bn1on0066.outbound.protection.outlook.com ([157.56.110.66]:26052 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751478AbcCEGnq (ORCPT ); Sat, 5 Mar 2016 01:43:46 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: opensource.altera.com; dkim=none (message not signed) header.d=none;opensource.altera.com; dmarc=none action=none header.from=opensource.altera.com; Date: Sat, 5 Mar 2016 00:36:16 -0600 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 4/5] ARM: socfpga: Enable Arria10 L2 cache ECC on startup In-Reply-To: <1456850301-22066-4-git-send-email-tthayer@opensource.altera.com> Message-ID: References: <1456850301-22066-1-git-send-email-tthayer@opensource.altera.com> <1456850301-22066-4-git-send-email-tthayer@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN2PR80CA017.lamprd80.prod.outlook.com (10.141.39.155) To BN3PR03MB1365.namprd03.prod.outlook.com (25.163.34.151) X-MS-Office365-Filtering-Correlation-Id: cde997cf-b524-48e1-6908-08d344c17e45 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1365;2:k7LXiCcEIy9jGsAcJLepRm04ogd670sSy0q9CzN1B1ovRIr4cvq9fNZBpJB1W8Y9ZiuCdXga7yUqRiPssVbcVXn4d8Tppm3ku/yOX9Q0igXIH5i+4ZZMQQ/GXjJ0sjeRuj2iB2ahSGdPF0+3xTH6gDtKB5J8xXUPFdx9Cl0o0rLPyFmUlx77GMwjASLWM1iC;3:TUiFjLz0fGjEmzYDeRmoqWclpE5jCzYJmBk9+5qYOrV51U2cx/smKZSJA1+j0U8doV+ei5IuuC+JnlwcVApGnTcehuji/bpmm/JZPdLAp8688jp064FgV6Trnu7a+4ob;25:33PjXI9b8f74F8FbM0u/EYJ9Trgo7PSh+cKQeNdHfJXUfNLtg22s41ghv54YqkP9ipkxX3D1dZdYZDWlcvU8wulUDYzanB4bBAVQzbhn74dtswXz74BdyuUuNtwzGZJFG0wyKYb5TSJmeGn8y5bkT3B8KjZgXg+n14mIOPBmV8Pzh9LFKpDrb1Daf9ZKJGaSnDmYEQki4OCHwisavK5Ju+4h+bS/+VN4fGdAiHrmHco1tnjZxo18U3dC931sX+p0GE1tFaEiMC3oFl3RKpMsh3k8Au8ba7qOMT8gVbhus3qoDMcP0ftak17ehBh+6tI+7VtL0nke8HpYGp333vUBIg==;20:XZKlbLU800Z8MENQb/DBZJJrAOT7kK7XyPaf+5M+QwGDd3PY4EYuh+RZ96QNS5rhLQ+OU0eDkQcK0x9RztQ5FLRBWddlEYmxYmx9O8SE9ClIGR+g5Whb4gnWZELGeEpZM1PV/bFKZWssURXwDd3Xvf6mEH6XZIqlsvLyb8xJrpo= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1365; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR03MB1365;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1365;BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(5005006)(8121501046)(13018025)(3002001)(10201501046);SRVR:SN2PR03MB046;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB046; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1365;4:KTTwDYZH8aLQv5bZ36sjBx09JYC3HB/Ej30ikXiNhk6dLhkQYL5u61evjxWIqKSmOx2hdwKWKXmKbMxifXxoFQ44CovgQPhDaBzEQdBnsgOyx88kxReuZ6FA0r3sdlwc6/8YUPwjhOox0IGr5YVboo7kflfnKWbx1gdpQtVqmUnTGA8JQLqjFQz2mPtf/J4usApy4pvB1oksXlrqMNQb4sxsdZoP74IeMCwk8w16QuSaIIY+RrkInMwhC0hokYITocBDT1MokH0b2VTTKwr6Qnd+oz6IgpcZmxK5XxAEAm9W9wDxYfFoeeZW2xeFXyMq1lOgm5yb6WOmr1uxJsTHSKt7a4nWGsk5VwOGaJql+4iXLueM6fkL+CLaKVQdsdiv X-Forefront-PRVS: 087223B4DA X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(81166005)(92566002)(19580405001)(83506001)(19580395003)(1096002)(54356999)(76176999)(77096005)(47776003)(50986999)(66066001)(50466002)(4001450100002)(53416004)(2906002)(4326007)(2950100001)(86362001)(110136002)(122386002)(40100003)(33716001)(5004730100002)(189998001)(2351001)(586003)(23726003)(5008740100001)(6116002)(42186005)(3846002)(46406003)(4001350100001)(87976001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1365;H:linux-builds1.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1365;23:iKdYqL/dakllq4TIbxNlbwJZGmCZWFvOCogE/gz+G?= =?us-ascii?Q?xCs1EM1abEOZdwA2Sc4cd0alX7Mu/FloWDRiAemgy59eoOn1cDvOQxNI59M7?= =?us-ascii?Q?6Z5SxtU9o+sU8Vfd30xdmZpshQ9S0txj7raJSoseTHBlOz5jCYQpLsrbdDHf?= =?us-ascii?Q?JJ7Bzdm/HTGX5B2powXChyBll8UBjjZEmTHcU2and1UvlfdWHZoh2JWLeA2F?= =?us-ascii?Q?uxFyAxlW1eHw00nvf5OucXrvsi3dT5R+6hsJKwRPwXhhgQ3kMIO6Y+c7RTsw?= =?us-ascii?Q?IkMUXGZ0eKhI0ISHdDwx/WFTZ9i2/uq4/fRDQWz4tYclGaYlOD6LIb3ux4ZZ?= =?us-ascii?Q?lTzTeK5dKwQOTjTe1yPj/lHgks6/fWo/2XDnms2apBW+XWx0S2nsPoZIrvgg?= =?us-ascii?Q?+Xel/b3zFxrgpMLss7Gr6Q1za66sLrrPTv39tLnxiJrPCplMyka0z7WweVZ9?= =?us-ascii?Q?iyc/sZDugrGzJJgVCLX25Lv1TtKl6nDfgnqACNzlsOfpHCbfs0O2jY58kQhp?= =?us-ascii?Q?11M60n4kYKo3ytK6xaxBfV5gZOpQw3ohZewzVRWxlfmsqUuEJkIAzI5yC6GH?= =?us-ascii?Q?EplW9mq153UxgNAw/6cTXGFjTWhpwFLEn/CJhHso+W4PSITsurHkqPrlbeQK?= =?us-ascii?Q?zC6/6fjuq+x7CaIZXN1Le7dTEL47t2hX4NnL7gqqahP6FPFCwSWfQZEUFtn4?= =?us-ascii?Q?IFHZW79T68FCRg0PXKFctoQvKdBUcTw5FYubBlh9BLOEa2XQbyeHmnjZhP84?= =?us-ascii?Q?h1gs92QCOSYAzPBCGolRDCML73kO8jvipwRrnFDwjj9+/BUqeGCDG/2mveiC?= =?us-ascii?Q?09f1X/SAYlXSyPZBuy4/9PZoZiShsPgTDlsKga9ZMYNwdcpuMlPfgfY5K8Jw?= =?us-ascii?Q?0wOwdDkPuThSxr/NdkQdf+PWyk2jGo9fJpd7zdUiY7R5j+w+u+46tgpgN5py?= =?us-ascii?Q?JFbFF9jOEeF05qpmyfxVMn9oJCwOHkC1jxuJigil+gBkfR6+vR8Rph0rhny9?= =?us-ascii?Q?OAMoaE4W2P94pOWppEhYJYUnuMK3QBTDZgVh+iRh8Gubg=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1365;5:HjbmXwP5pJDSDZSBZurukkKWxN1RNyFTZ/L+Qax7TOCm0HN5K7qDS7UBBPGky8UTHIKd7t36zhf4nMrRxBMzAr8yyu1hn/p0vpeEqR91A2jeh/ZlilddowNnnlQrSbiA8xbAlETD5cnRKv+sn+/v4w==;24:wCeOw1Mdn54caH1syzv/8ogSJNwXX+LXl+/7u1fUIiE0tJyvB8/oPsxGksoyjQ13B8jjAUJsL3EKBNXv8G4eQlcjqJsOikeGABDC169D5dg=;20:bSlMJ6+eqTDRcBlOjQwgxH0/hxHBnsTpvVyUgVWOR2p5GBzQV+WFp82FhKUXhuEZmlPOYtrXAFoDOSc8rZOzF5PurM4nrKEUN8YuemykbHAAF9MN4KoKbSeWK3iTljZsEhr24oGDJWRGW33SyhZ4fwqmvFblTLqfbUTyxqzIX4Q= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1365 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD006.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(50466002)(4001450100002)(3720700001)(53416004)(5008740100001)(5004730100002)(23726003)(2950100001)(1096002)(1220700001)(47776003)(4001350100001)(2351001)(46406003)(189998001)(92566002)(66066001)(87936001)(81166005)(33716001)(19580405001)(19580395003)(86362001)(105606002)(4326007)(16796002)(54356999)(40100003)(76176999)(11100500001)(956001)(122386002)(6116002)(50986999)(85426001)(77096005)(6806005)(106466001)(3846002)(2906002)(586003)(83506001)(110136002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR03MB046;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD006;1:4s9+GDGsb20vM5WGRjL1HZBGdDHyzLqjA6QA6xZaxtGRH4yFcyt5uZ5WND23z/FnmbeVhHVCZTwve45m81anqiL7vtedwEhepQob7Q0QKlj9Zmy3EZVlRoZohuxAnO9kFRSODJBlMmQhDIJLPQaqEi6NzviucqpjEichTTM5kHC0MTLng3izpgq0+12ox0nxfGRWuqAzQ2QF1qIKGgAjyKs8oMh+9zbRmS3U9T0OVb8h/ePeG4hyYzqOVm+KNTjs6pbVm8eMnYEo7kFT5FQkD/cOR58Lc74diJ9Jw7T7NEP1KHUVEZC2o9xMU24YQMbcV3RaRqjwprGtqJIrCcG1UFofywa2dxnbT6z4Ut/mjmC9CXXRo4Do2sQmf8WTVI+PtOtcdZ+FmoaH8HO2wCdU977Dt0VHjiGOZoHFRtd4h9CLyj4q4q4Quc9Q0DQ5OzHcG7F6gfK9l/ZoIiOzuUxrIQURPxmnfUvgYPYCBAnMB2s= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;2:ns4l9zMhZkVw2UMvS4R5o5nUsnONq7cDqar3acuF2gMH1ME4iBskb+0fBytOVZ3ecGgA7yQUzQWmmKvU5u90zf13WvJs4pam/XuezPFC5m153FZZF/2UpVgBU9ODm87J4dcn/njCFtNkEpP59GUwSrKosLt6W+ZRSQxwWVZvZecHLGX+08HFxI45XhMxoPMo;3:xwCKzc+gTzGE1DZ2xIQXuL397oncvXX08M1wjUwgHJgQA3oCSrPgc+eljC7lc+xJTkR8HxcGlQStpTATf2BIAom1NwHIhP7F+Ef47+liQDg8mltu3JVluOq8SEbwjOKJmIlWkv3FhPjCDVUJ5Xizx6JWuxMEKh/oa9U4npMvkBC6FQzfNekK5DvkrXs0kjMcexrDthr/TmV/GSUOWm9eiQt/W1inEeoG01Fqs1XCkYkyihfeKprLIpK0ra1L3ALi;25:hZeGFlZWG8U+S8mPqy0/ZSHLyzBo0LPrC6jLulyiN2jQ01U9QICczbZhdl9id3oaHvwNxunoIADsFiNvSCBqzanUnQFFVShdiitKV5aJh51o0f4dOPlou50P5WKYYlDmbvVvUOC/VkqEH84rmhhl2waeDCQ+brt+zJMowvWaYKOMbu6BFRgy2fgrSr/MDP23loNkpOq6gNCELdrB+JGAHVQ6rv0qmw5uka8xtPTVDoS7rW9OaqllnrFR7N2FBpCGlKNCJveLQfWCG1pku2xPQE3GIistkAr1pVFUxwjXjck8cAZQSeeketl+goDPDTQcn2pEZhpnawozKLpDBx2EsbF4btDgimMg1D74FnE5ZGml8umanghCH1mV7O6Ru6PjCnjp11sfmm+8vtq9RCVqSA== X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:SN2PR03MB046; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;20:uprxBaaIe/LRWqdvEugxqQ3Ux0ltcEnzsIiS8tyZy4U2aH9cshWwfECthsD3tqZqkS1ZXZB5Es87MTYzxXfL4u0NRPMTzhPhc/mUZNMvfJACCVVDvtF/hoZQjRwfJZY3ff1L31IVj0cjELa2ef3BIpuxIcCSX4vfL17unCZGxFI=;4:RLSH2MjsmSgqQjX4oFZZ5FPArO+2WX13vCn7mrCyTOS29o4adNjSxkpewA5dpCgSyjOuP2hqProGIHoJzrKoe/ha40vHSlExUN84I4t4xZQDC3qDbQyFPlalF+UvexE7KjjccqWZTJrqwytzQjNvXcEnEhdxI870JbL5anjqSvNJqfv9oQzJ4P4ShRPNaMjv5zpafrAlzYz5FUwUp7/sSAswVTbzs2/MqQ+Th2Lev545QRKgEhVbr3Wo3UcK2DnbrBpZxLm0QL69O+BLe7xsOBHtly7MUBEIOLGqAIAYTdJnc5xWhAFx8fmWbKZiixdPBATwrmGTG6NEstoUj8Kvse+sjKeQvcFG1mL/q+N4DwDt4YkVPRSKrfb+Q0X1TjxIYv42wsqMUJLdAkbFxR7lc3WoGdqpNIy1oiqW8mgWsCyXjmZzvx/RqxergxK9jqjpMHwN/hCu7qDymijyB/phwQ== X-Forefront-PRVS: 087223B4DA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR03MB046;23:CSK/JSbD/1qmnPZpXgS1TDogcOYRYg7in97Tl3OrxA?= =?us-ascii?Q?xnuhiARt+Xb8dgELLkzF5Yy1rjKj55PxhnV53S+HXkkixooU7Vfcrs8mSnVs?= =?us-ascii?Q?KVh3f2vrBCqzva06EzQTXnYI7FT3lXqiUATHRsSe4xVMLoszE9ZWROoT+xJM?= =?us-ascii?Q?2AvyxR0wb6L8IHNqIvv23Q91Th5WIUST6jS+g/xFOPbm7p2L6e1eYvzqhQXw?= =?us-ascii?Q?fbrPl2XmdtWDuYbb79N/WhtLzwH8eGe47h77GoVZ6paXA4mt2nnsuZY3wL7n?= =?us-ascii?Q?DRITK0mKFvMGZQaPhWeLWxHBHt5jvkUHL0og4Z0G/FuhTT+oyD0xbaafLMYO?= =?us-ascii?Q?AJuETpn+fHMDzmLUgmw+/nS2Ooo6NNdoZr2a6m63rM1Eb7669ZsdTO5BVbD7?= =?us-ascii?Q?71FTKcJ/a1EOmLgKY2MPLz02bxezDGH9NSfEkRQVinFRxAxqIEoqPhnR76tz?= =?us-ascii?Q?Jx+UYRfUsC2JnCQKr5qtuaUkwBxTn84u5Noy2gOMecb9OStX+p1GaQZSGYOJ?= =?us-ascii?Q?gOPsLWCSh+eNgq7dcAaX+zlS17zVdwRON0stRFtVFZ6iqXX/jXCrD9wxcG7W?= =?us-ascii?Q?X90Wcvq9FnvuK9Y5EYnmaVB+0UYcWiLEjtx2B52k+MNVozbCqpa6PKkdbi+e?= =?us-ascii?Q?kX4DwHoMkXJUiJWV9AR/8nVO/VMQHDzD67dBejeNu4Mv4tqkDOrleYnaN2bi?= =?us-ascii?Q?j4xx9qxDMFFktom+QDe7IPEZ7yTQMidZ3W//EgY8tnCHKp/zxNsy0TuWjcFA?= =?us-ascii?Q?u3pPjTfcFbGCWXd8yIVlUR8bXcxc6hdgUZexxB/wnBlCg1LK1MmF690nTvdO?= =?us-ascii?Q?hcdob4pC7N9Dft22fLTDQzYNaY5UnY86uNq9gmhWWjz4gIdr1c0oC7ksrhY4?= =?us-ascii?Q?4LSgQ+8jGcCKyDMyngz/4WabROAueks+FTPxvkRqnRG9q1NfHvFasGIc/nuU?= =?us-ascii?Q?uzu7jYCDO0wjMn9lpMVFPeqSvMFHbJx1YK0gtvR+9jejV3TnWeIRP+hX7zgz?= =?us-ascii?Q?kxsJDJ1DRKNXjI4yYV14qu0yCFrJPzHS0D9hQr4BkKHtPRERJKLn8KbKfWHh?= =?us-ascii?Q?hxVyVbrhcwxEVhm2vr5QLmqujnkNtHtZWCBkUYj+maiiDen6sOGMCnQRZV2r?= =?us-ascii?Q?po+AqAMI4a6Gh/S/t1w2KIhZdHewkxXFPeZO1fcY/TzicC0MBDtQ9Gk0w1Sy?= =?us-ascii?Q?hJP39+APYq0d5lHFLy9GrC7auhrkL72xpYZXPdOBL+VSjpWqqLUBUFvQL3Z/?= =?us-ascii?Q?DF3BRpcVchWgwDIKdvYc2LUiihhf5mvp0GqZM7WIwDriSgabnaibeDpP81cO?= =?us-ascii?Q?mti+bWRcetqSFCyQ9E15U=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB046;5:PXbg/SrLfpGxlmCraS9uoOjiG3ykOjcqYVLlxA1gJnw9t4Et/1q9sdy1zUjcm1VOTc7hx/pvmEfxJ/YBRhKSc1R/dXtkiftWznyLzlf6iO6mcDK8qGHTcXG4w01XcimLptyopTDOuCFwznG4D7YskQ==;24:kXr4cjJ72e/g04rQrp4EjqGUaiFbS1S7PVq5tQpeqbboTFbNBMyfgZqloxTaCirfXGtaYahINsY1MwLdwzztr+X8U2tCdGQAayT50YrPpcI=;20:ATvXPVdJ+TpA6yBqZBzeGeAOipVVF9cUQvRNstuOR0eg123qCo35Fbk/zpGx+LJRVqtZ95MhOHV8BVKKmt3rJiMFbBxOqPwI/kaq/un7/KI0VrtCP6FPBwGq22AlaYFsPJKVsXoVf3W+etECP6NmiiNk4k5vgw1D7O+skQEneS4= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2016 06:43:42.3170 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB046 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Mar 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > Enable ECC for Arria10 L2 cache on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > > Signed-off-by: Thor Thayer > --- > arch/arm/mach-socfpga/l2_cache.c | 42 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 38 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-socfpga/l2_cache.c b/arch/arm/mach-socfpga/l2_cache.c > index e3907ab..b197218 100644 > --- a/arch/arm/mach-socfpga/l2_cache.c > +++ b/arch/arm/mach-socfpga/l2_cache.c > @@ -17,14 +17,31 @@ > #include > #include > > +#include "core.h" > + > +/* A10 System Manager ECC interrupt mask control registers */ > +#define A10_L2_ECC_CTRL_OFST 0x0 > + > +#define A10_SYSMGR_ECC_INTMASK_CLR_OFST 0x98 > +#define A10_L2_ECC_INT_CLR_OFST 0xA8 > + > +#define A10_MPU_CTRL_L2_ECC_EN BIT(0) > +#define A10_ECC_INTMASK_CLR_EN BIT(0) > +#define A10_ECC_INT_CLR (BIT(31) | BIT(15)) > + > void socfpga_init_l2_ecc(void) > { > struct device_node *np; > void __iomem *mapped_l2_edac_addr; > + const char *compat = "altr,socfpga-l2-ecc"; > > - np = of_find_compatible_node(NULL, NULL, "altr,socfpga-l2-ecc"); > + if (of_machine_is_compatible("altr,socfpga-arria10")) > + compat = "altr,socfpga-a10-l2-ecc"; The ARM maintainers have made comment to me about about trying to not sprinkle these of_machine_is_compatible() all over the place. You should make the decision during the initial probe of the machine. Please look at how the .restart is differentiate between the 2 platforms. > + > + /* Find the L2 EDAC device tree node */ > + np = of_find_compatible_node(NULL, NULL, compat); > if (!np) { > - pr_err("Unable to find socfpga-l2-ecc in dtb\n"); > + pr_err("Unable to find %s in dtb\n", compat); > return; > } > > @@ -35,7 +52,24 @@ void socfpga_init_l2_ecc(void) > return; > } > > - /* Enable ECC */ > - writel(0x01, mapped_l2_edac_addr); > + if (of_machine_is_compatible("altr,socfpga-arria10")) { Same comment as above here. BR, Dinh