From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Brad Mouring <bmouring@ni.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 1/1] rtmutex: Handle when top lock owner changes
Date: Fri, 6 Jun 2014 07:40:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1406060739030.23174@nanos> (raw)
In-Reply-To: <20140605231940.1fc277a4@gandalf.local.home>
On Thu, 5 Jun 2014, Steven Rostedt wrote:
> On Wed, 4 Jun 2014 17:32:37 +0200 (CEST)
> Thomas Gleixner <tglx@linutronix.de> wrote:
> + /*
> + * When we dropped the spinlocks, if the owner of the lock we
> + * are currently processing changed since we chain walked
> + * to that lock, we are done with the chain walk. The previous
> + * owner was obviously running to release it.
> + */
> + if (lock && rt_mutex_owner(lock) != task)
> + goto out_unlock_pi;
NO. You CANNOT derefernce lock after dropping the locks. It might be
gone already.
Thanks,
tglx
next prev parent reply other threads:[~2014-06-06 5:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400855410-14773-1-git-send-email-brad.mouring@ni.com>
[not found] ` <1400855410-14773-2-git-send-email-brad.mouring@ni.com>
2014-06-04 1:06 ` [PATCH 1/1] rtmutex: Handle when top lock owner changes Steven Rostedt
2014-06-04 13:05 ` Brad Mouring
2014-06-04 14:16 ` Steven Rostedt
2014-06-04 14:38 ` Brad Mouring
2014-06-04 14:58 ` Steven Rostedt
2014-06-04 15:11 ` Brad Mouring
2014-06-04 15:32 ` Thomas Gleixner
2014-06-04 15:44 ` Steven Rostedt
2014-06-04 18:02 ` Thomas Gleixner
2014-06-04 18:12 ` Steven Rostedt
2014-06-04 20:49 ` Thomas Gleixner
2014-06-04 19:25 ` Brad Mouring
2014-06-04 19:53 ` Thomas Gleixner
2014-06-04 20:07 ` Brad Mouring
2014-06-04 20:41 ` Thomas Gleixner
2014-06-04 22:22 ` [PATCH] " Brad Mouring
2014-06-04 23:03 ` Thomas Gleixner
2014-06-06 3:19 ` [PATCH 1/1] " Steven Rostedt
2014-06-06 5:40 ` Thomas Gleixner [this message]
2014-06-06 5:44 ` Thomas Gleixner
2014-06-06 8:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1406060739030.23174@nanos \
--to=tglx@linutronix.de \
--cc=bmouring@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox