The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"<HPDD-discuss@lists.01.org>" <HPDD-discuss@ml01.01.org>,
	"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
	"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: lustre: question about lov_request.c
Date: Mon, 8 Jun 2015 09:24:42 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1506080923210.2660@hadrien> (raw)
In-Reply-To: <4ED30946-5333-4684-9498-B734D991847A@intel.com>

>   You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now,
>   so it's safe to drop the whole if and also the struct member itself.
>   set_oabufs could be dropped as well.

Looking further, in the same function I also don't see any other uses of
the tested field in:

                if (req->rq_oi.oi_md)
                        OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);

        if (set->set_lockh)
		lov_llh_put(set->set_lockh);

Can these be dropped as well?

thanks,
julia

  parent reply	other threads:[~2015-06-08  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-07 20:11 lustre: question about lov_request.c Julia Lawall
2015-06-07 20:58 ` Drokin, Oleg
2015-06-07 21:06   ` Julia Lawall
2015-06-08  7:24   ` Julia Lawall [this message]
2015-06-08  7:58     ` Drokin, Oleg
2015-06-23  6:23       ` lustre: LIBCFS_ALLOC Julia Lawall
2015-06-23  8:30         ` Drokin, Oleg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1506080923210.2660@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox