From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752518AbbG1PhZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 11:37:25 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:38379
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750886AbbG1PhY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 11:37:24 -0400
X-IronPort-AV: E=Sophos;i="5.15,563,1432591200"; 
   d="scan'208";a="141405959"
Date: Tue, 28 Jul 2015 17:37:16 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Joshua Clayton <stillcompiling@gmail.com>
cc: Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Nitin Kuppelur <nitinkuppelur@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates
 to rates
In-Reply-To: <ab892a76a6b2b320906357569fde7fa33ff04920.1438057939.git.stillcompiling@gmail.com>
Message-ID: <alpine.DEB.2.10.1507281735430.2343@hadrien>
References: <cover.1438057939.git.stillcompiling@gmail.com> <ab892a76a6b2b320906357569fde7fa33ff04920.1438057939.git.stillcompiling@gmail.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 83d4bca..1ded691 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
>  	/* Add the protocol name */
>  	iwe.cmd = SIOCGIWNAME;
>  	if ((r8712_is_cckratesonly_included(pnetwork->network.
> -	     SupportedRates)) == true) {
> +	     rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
>  		else
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
>  	} else if ((r8712_is_cckrates_included(pnetwork->network.
> -		    SupportedRates)) == true) {
> +		    rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
>  		else

The placement of the line breaks here is partucularly unpleasant.  Perhaps
that could be adjusted now that the field name is shorter.  Theer may be
some other cases in the patch where the line breaks could be adjusted to
improve readability.

julia