From: Julia Lawall <julia.lawall@lip6.fr>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
Joe Perches <joe@perches.com>, Jiayi Ye <yejiayily@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org
Subject: Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.
Date: Tue, 4 Aug 2015 15:34:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1508041533050.2327@hadrien> (raw)
In-Reply-To: <1438693573-5310-2-git-send-email-shraddha.6596@gmail.com>
Sorry not to have been more clear. The original subject text was OK.
Tehway to differentiate between the patches would be to put Staging:
lustre: mgc: in thi case, and Staging: lustre: libcfs: in the other one.
julia
On Tue, 4 Aug 2015, Shraddha Barke wrote:
> Replace comma between expression statements by a semicolon.
> The semantic patch used is as follows:
>
> @@
> expression e1,e2;
> @@
> e1
> - ,
> + ;
> e2;
> ---
> Changes in v2:
> -Make subject more clearer.
>
> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index 562bd95..019ee2f 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
> pos += sprintf(obdname + pos, "-%s%04x",
> is_ost ? "OST" : "MDT", entry->mne_index);
>
> - cname = is_ost ? "osc" : "mdc",
> + cname = is_ost ? "osc" : "mdc";
> pos += sprintf(obdname + pos, "-%s-%s", cname, inst);
> lustre_cfg_bufs_reset(&bufs, obdname);
>
> --
> 2.1.0
>
>
next prev parent reply other threads:[~2015-08-04 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:06 [PATCH v2 1/3] Staging: lustre: Replace comma with a semicolon Shraddha Barke
2015-08-04 13:06 ` [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by " Shraddha Barke
2015-08-04 13:34 ` Julia Lawall [this message]
[not found] ` <CAO393AAyJ-OTz+yfGsHdaKeyyXT3Y8EMoxgVJzoZCjXRB=UJGg@mail.gmail.com>
2015-08-04 13:45 ` Julia Lawall
2015-08-04 13:06 ` [PATCH v2 3/3] Staging: netlogic: Replace comma with " Shraddha Barke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1508041533050.2327@hadrien \
--to=julia.lawall@lip6.fr \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=shraddha.6596@gmail.com \
--cc=yejiayily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).