From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754520AbbIQIqa (ORCPT ); Thu, 17 Sep 2015 04:46:30 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:16498 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753907AbbIQIqT (ORCPT ); Thu, 17 Sep 2015 04:46:19 -0400 X-IronPort-AV: E=Sophos;i="5.17,545,1437429600"; d="scan'208";a="147578861" Date: Thu, 17 Sep 2015 10:46:16 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mark Brown cc: Julia Lawall , Patrick Lai , kernel-janitors@vger.kernel.org, Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument In-Reply-To: <20150914180425.GB12027@sirena.org.uk> Message-ID: References: <1440957911-7687-1-git-send-email-Julia.Lawall@lip6.fr> <1440957911-7687-2-git-send-email-Julia.Lawall@lip6.fr> <20150914180425.GB12027@sirena.org.uk> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Sep 2015, Mark Brown wrote: > On Sun, Aug 30, 2015 at 08:05:10PM +0200, Julia Lawall wrote: > > Apply PTR_ERR to the value that was recently assigned. > > > > The semantic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > I have no idea what's going on with this stuff without spending more > time than it looks like should need, there's a moderately big thread and > some patches posted in the middle of it. Can you repost whatever the > current state is please? The discussion was about introducing a temporary variable to simplify the code. But that makes a lot of changes, so I think it would be better to just apply the original bug fixing patch as is, and then the cleanup could be applied on top of that. I will submit the original patch again. julia