From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbbIZJpH (ORCPT ); Sat, 26 Sep 2015 05:45:07 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2419 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbbIZJpG (ORCPT ); Sat, 26 Sep 2015 05:45:06 -0400 X-IronPort-AV: E=Sophos;i="5.17,591,1437429600"; d="scan'208";a="179542659" Date: Sat, 26 Sep 2015 11:45:03 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Julia Lawall , Andrzej Hajda , Bartlomiej Zolnierkiewicz , Gilles Muller , Marek Szyprowski , Michal Marek , Nicolas Palix , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH] coccinelle: assign signed result to unsigned variable In-Reply-To: <56066866.1060602@users.sourceforge.net> Message-ID: References: <1443099286-16559-1-git-send-email-a.hajda@samsung.com> <56041BE5.5010005@users.sourceforge.net> <56051D2B.5040802@samsung.com> <56064D0B.8060907@users.sourceforge.net> <56066866.1060602@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Sep 2015, SF Markus Elfring wrote: > > To collect function calls that have a return value of a given type t, > > it should be sufficient to do the following: > > > > @@ > > t e; > > identifier f; > > @@ > > > > f(...)@e > > Is such a SmPL approach better than a variant like the following? > > @find_function@ > type t; > identifier f; > @@ > t f(...) > { ... } Your approach finds a function definition. My approach works on the call directly, using whatever type information is available. julia