From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966618AbcHEKIo (ORCPT ); Fri, 5 Aug 2016 06:08:44 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60944 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcHEKIn (ORCPT ); Fri, 5 Aug 2016 06:08:43 -0400 X-IronPort-AV: E=Sophos;i="5.28,473,1464645600"; d="scan'208";a="186962677" Date: Fri, 5 Aug 2016 12:08:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Johannes Berg cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool In-Reply-To: <1470389433.2977.31.camel@sipsolutions.net> Message-ID: References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr> (sfid-20160805_111640_944584_00A38E89) <1470389433.2977.31.camel@sipsolutions.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1410669134-1470391715=:2999" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1410669134-1470391715=:2999 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 5 Aug 2016, Johannes Berg wrote: > > > - if (of_get_property(pdev->dev.of_node, > > -     "little-endian", NULL)) > > + if (of_property_read_bool(pdev->dev.of_node, "little- > > endian")) > >   priv->is_little_endian = true; > >   else > >   priv->is_little_endian = false; > > > > Perhaps, while changing this, that'd be better as > > priv->is_little_endian = of_property_read_bool(...); > > Obviously that would've worked before, but now it'd be even easier to > understand, it seems. Can I do the same for: if (of_property_read_bool(np, "phy-clk-valid")) pdata->check_phy_clk_valid = 1; else pdata->check_phy_clk_valid = 0; The type is not bool, but: include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1; thanks, julia --8323329-1410669134-1470391715=:2999--