From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755891AbcH1Rqx (ORCPT ); Sun, 28 Aug 2016 13:46:53 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:6964 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbcH1Rqw (ORCPT ); Sun, 28 Aug 2016 13:46:52 -0400 X-IronPort-AV: E=Sophos;i="5.28,592,1464645600"; d="scan'208";a="234317832" Date: Sun, 28 Aug 2016 19:43:43 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Fengguang Wu , linux-kernel@vger.kernel.org, keescook@chromium.org Subject: Re: constification and cocci / kernel build test robot ? In-Reply-To: <1472405969.26978.90.camel@perches.com> Message-ID: References: <1472325098.26978.14.camel@perches.com> <1472405969.26978.90.camel@perches.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-2121247967-1472406224=:3419" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2121247967-1472406224=:3419 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT On Sun, 28 Aug 2016, Joe Perches wrote: > On Sun, 2016-08-28 at 15:13 +0200, Julia Lawall wrote: > > [Adding Kees, in case it's of interest] > > > Below is the list of types of top-level initialized structures and the > > number that are const.  For quicker reading, here are some that are > > sometimes const (numerator), but not always (denominator): > > [] > > And here is the checkpatch list: > > # check for various structs that are normally const (ops, kgdb, device_tree) > my $const_structs = qr{ > acpi_dock_ops| > address_space_operations| > backlight_ops| > block_device_operations| > dentry_operations| > dev_pm_ops| > dma_map_ops| > extent_io_ops| > file_lock_operations| > file_operations| > hv_ops| > ide_dma_ops| > intel_dvo_dev_ops| > item_operations| > iwl_ops| > kgdb_arch| > kgdb_io| > kset_uevent_ops| > lock_manager_operations| > microcode_ops| > mtrr_ops| > neigh_ops| > nlmsvc_binding| > of_device_id| > pci_raw_ops| > pipe_buf_operations| > platform_hibernation_ops| > platform_suspend_ops| > proto_ops| > rpc_pipe_ops| > seq_operations| > snd_ac97_build_ops| > soc_pcmcia_socket_ops| > stacktrace_ops| > sysfs_ops| > tty_operations| > uart_ops| > usb_mon_operations| > wd_ops}x; > > While I don't know that Julia's "always const" list is > completely appropriate given possible local naming clashes, > maybe checkpatch can use some separate file with the > structs enumerated like a .checkpatch_const_structs file or > similar to make this more easily editable. Could be a good idea. julia --8323329-2121247967-1472406224=:3419--