From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757010AbcILIr4 (ORCPT ); Mon, 12 Sep 2016 04:47:56 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:39310 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754932AbcILIrz (ORCPT ); Mon, 12 Sep 2016 04:47:55 -0400 X-IronPort-AV: E=Sophos;i="5.30,322,1470693600"; d="scan'208";a="236075898" Date: Mon, 12 Sep 2016 10:47:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jarkko Sakkinen cc: Peter Huewe , joe@perches.com, kernel-janitors@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/26] tpm: constify local structures In-Reply-To: <20160911170937.GA5493@intel.com> Message-ID: References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> <20160911170937.GA5493@intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:52PM +0200, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > 2. Address never taken > > 3. Not passed to a top-level macro call > > 4. No pointer or array-typed field passed to a function or stored in a > > variable. > > Declare structures having all of these properties as const. > > > > Done using Coccinelle. > > Based on a suggestion by Joe Perches . > > > > Signed-off-by: Julia Lawall > > To be frank I don't understand (at all) what you are trying to say in > the commit message but change is still for better :) > > Can I rephrase the commit message: "Move TPM header structures to the > .rodata section"? It should be obvious why that is for better for > anyone. Sorry. I tried to explain what strategy I used to ensure the change was OK. If you want to change the commit message, then no problem. julia > > Anyway, thanks for the effort. > > Acked-by: Jarkko Sakkinen > > /Jarkko > > > --- > > The semantic patch seems too long for a commit log, but is in the cover > > letter. > > > > drivers/char/tpm/tpm-interface.c | 10 +++++----- > > drivers/char/tpm/tpm-sysfs.c | 2 +- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > > index 1abe2d7..e84888f 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -633,7 +633,7 @@ EXPORT_SYMBOL_GPL(tpm_get_timeouts); > > #define TPM_ORD_CONTINUE_SELFTEST 83 > > #define CONTINUE_SELFTEST_RESULT_SIZE 10 > > > > -static struct tpm_input_header continue_selftest_header = { > > +static const struct tpm_input_header continue_selftest_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(10), > > .ordinal = cpu_to_be32(TPM_ORD_CONTINUE_SELFTEST), > > @@ -659,7 +659,7 @@ static int tpm_continue_selftest(struct tpm_chip *chip) > > > > #define TPM_ORDINAL_PCRREAD cpu_to_be32(21) > > #define READ_PCR_RESULT_SIZE 30 > > -static struct tpm_input_header pcrread_header = { > > +static const struct tpm_input_header pcrread_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(14), > > .ordinal = TPM_ORDINAL_PCRREAD > > @@ -745,7 +745,7 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > > */ > > #define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > > #define EXTEND_PCR_RESULT_SIZE 34 > > -static struct tpm_input_header pcrextend_header = { > > +static const struct tpm_input_header pcrextend_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(34), > > .ordinal = TPM_ORD_PCR_EXTEND > > @@ -949,7 +949,7 @@ EXPORT_SYMBOL_GPL(wait_for_tpm_stat); > > #define TPM_ORD_SAVESTATE cpu_to_be32(152) > > #define SAVESTATE_RESULT_SIZE 10 > > > > -static struct tpm_input_header savestate_header = { > > +static const struct tpm_input_header savestate_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(10), > > .ordinal = TPM_ORD_SAVESTATE > > @@ -1032,7 +1032,7 @@ int tpm_pm_resume(struct device *dev) > > EXPORT_SYMBOL_GPL(tpm_pm_resume); > > > > #define TPM_GETRANDOM_RESULT_SIZE 18 > > -static struct tpm_input_header tpm_getrandom_header = { > > +static const struct tpm_input_header tpm_getrandom_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(14), > > .ordinal = TPM_ORD_GET_RANDOM > > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c > > index b46cf70..26fccad 100644 > > --- a/drivers/char/tpm/tpm-sysfs.c > > +++ b/drivers/char/tpm/tpm-sysfs.c > > @@ -22,7 +22,7 @@ > > > > #define READ_PUBEK_RESULT_SIZE 314 > > #define TPM_ORD_READPUBEK cpu_to_be32(124) > > -static struct tpm_input_header tpm_readpubek_header = { > > +static const struct tpm_input_header tpm_readpubek_header = { > > .tag = TPM_TAG_RQU_COMMAND, > > .length = cpu_to_be32(30), > > .ordinal = TPM_ORD_READPUBEK > > >