From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757451AbcILJnK (ORCPT ); Mon, 12 Sep 2016 05:43:10 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:33581 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756419AbcILJnI (ORCPT ); Mon, 12 Sep 2016 05:43:08 -0400 X-IronPort-AV: E=Sophos;i="5.30,322,1470693600"; d="scan'208";a="192824307" Date: Mon, 12 Sep 2016 11:43:05 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sergei Shtylyov cc: joe@perches.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 23/26] sh_eth: constify local structures In-Reply-To: Message-ID: References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-24-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > > 2. Address never taken > > Really? OK, I see the problem. The code has, eg: { "sh7724-ether", (kernel_ulong_t)&sh7724_data } Coccinelle doesn't know anything about kernel_ulong_t, so it assumes that it is an identifier, and that the whole expression is a bit and, rather than an address computation. And at the same time, the cast causes the compiler to discard the const annotation, so it doesn't complain either. I can update the rule to avoid this case, since taking a bit and on the address of a top-level structure is not likely to be useful, and I will check whether any of the other patches are affected by this issue. Thanks for the report. julia > > > 3. Not passed to a top-level macro call > > 4. No pointer or array-typed field passed to a function or stored in a > > variable. > > Declare structures having all of these properties as const. > > > > Done using Coccinelle. > > Based on a suggestion by Joe Perches . > > > > Signed-off-by: Julia Lawall > > NAK, see sh_eth_set_default_cpu_data(). > > MBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >