From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758017AbcILMBx (ORCPT ); Mon, 12 Sep 2016 08:01:53 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:62563 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbcILMBw (ORCPT ); Mon, 12 Sep 2016 08:01:52 -0400 X-IronPort-AV: E=Sophos;i="5.30,322,1470693600"; d="scan'208";a="236107675" Date: Mon, 12 Sep 2016 14:01:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mark Brown cc: joe@perches.com, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/26] spi: dw-pci: constify local structures In-Reply-To: <1473599168-30561-15-git-send-email-Julia.Lawall@lip6.fr> Message-ID: References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-15-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. Please ignore this patch. The file contains eg { PCI_VDEVICE(INTEL, 0x0800), (kernel_ulong_t)&spi_pci_mid_desc_1} which Coccinelle was incorrectly interpreting as a bit and operation, due to not realizing that kernel_ulong_t is a type. julia > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/spi/spi-dw-pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-dw-pci.c b/drivers/spi/spi-dw-pci.c > index ef7db75..60198a3 100644 > --- a/drivers/spi/spi-dw-pci.c > +++ b/drivers/spi/spi-dw-pci.c > @@ -29,13 +29,13 @@ struct spi_pci_desc { > u16 bus_num; > }; > > -static struct spi_pci_desc spi_pci_mid_desc_1 = { > +static const struct spi_pci_desc spi_pci_mid_desc_1 = { > .setup = dw_spi_mid_init, > .num_cs = 5, > .bus_num = 0, > }; > > -static struct spi_pci_desc spi_pci_mid_desc_2 = { > +static const struct spi_pci_desc spi_pci_mid_desc_2 = { > .setup = dw_spi_mid_init, > .num_cs = 2, > .bus_num = 1, > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >