From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755507AbcIMH1Q (ORCPT ); Tue, 13 Sep 2016 03:27:16 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:9782 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754886AbcIMH1O (ORCPT ); Tue, 13 Sep 2016 03:27:14 -0400 X-IronPort-AV: E=Sophos;i="5.30,327,1470693600"; d="scan'208";a="236216175" Date: Tue, 13 Sep 2016 09:27:11 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Namrata A Shettar cc: Ian Abbott , hsweeten@visionengravers.com, gregkh@linuxfoundation.org, badbuddha91@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-714071184-1473751631=:3355" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-714071184-1473751631=:3355 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 13 Sep 2016, Namrata A Shettar wrote: > This patch removes an unnecessary blank line that caused checkpatch issue. Actually, commit messages and subject lines should be written in the imperative. So you should say eg Remove unnecessary blank line instead of Removes unnecessary blank line julia > > Signed-off-by: Namrata A Shettar > --- > Changes in v2: >   - Changed the subject line >   - Changed description of patch > >  drivers/staging/comedi/comedi_pcmcia.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedi_pcmcia.c > b/drivers/staging/comedi/comedi_pcmcia.c > index d7072a5..ec8a0ad 100644 > --- a/drivers/staging/comedi/comedi_pcmcia.c > +++ b/drivers/staging/comedi/comedi_pcmcia.c > @@ -18,7 +18,6 @@ > >  #include >  #include > - >  #include "comedi_pcmcia.h" > >  /** > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDErWX1NgsruZtt10hi > hZR2J3cvK-Q9Zj_dp_GLc_0mLmA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-714071184-1473751631=:3355--