From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757930AbcIMJgL (ORCPT ); Tue, 13 Sep 2016 05:36:11 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:4646 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755679AbcIMJgJ (ORCPT ); Tue, 13 Sep 2016 05:36:09 -0400 X-IronPort-AV: E=Sophos;i="5.30,328,1470693600"; d="scan'208";a="192956096" Date: Tue, 13 Sep 2016 11:36:04 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Arnd Bergmann cc: outreachy-kernel@googlegroups.com, Namrata A Shettar , Ian Abbott , hsweeten@visionengravers.com, gregkh@linuxfoundation.org, badbuddha91@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line In-Reply-To: <2284008.DIPsHg5UWl@wuerfel> Message-ID: References: <2284008.DIPsHg5UWl@wuerfel> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2016, Arnd Bergmann wrote: > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote: > > --- a/drivers/staging/comedi/comedi_pcmcia.c > > +++ b/drivers/staging/comedi/comedi_pcmcia.c > > @@ -18,7 +18,6 @@ > > > > #include > > #include > > - > > #include "comedi_pcmcia.h" > > > > /** > > > > I would argue that checkpatch is wrong here, it's very common to have > an empty line between the global and the local header files. I forwarded this to Joe Perches, and he pointed out that checkpatch doesn't give a warning for this. Namrata, what version of the kernel are you using? julia > > Arnd > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2284008.DIPsHg5UWl%40wuerfel. > For more options, visit https://groups.google.com/d/optout. >