From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250AbcIMJ5S (ORCPT ); Tue, 13 Sep 2016 05:57:18 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:20836 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbcIMJ5R (ORCPT ); Tue, 13 Sep 2016 05:57:17 -0400 X-IronPort-AV: E=Sophos;i="5.30,328,1470693600"; d="scan'208";a="192959292" Date: Tue, 13 Sep 2016 11:57:12 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Namrata A Shettar cc: outreachy-kernel , arnd@arndb.de, abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, badbuddha91@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line In-Reply-To: Message-ID: References: <2284008.DIPsHg5UWl@wuerfel> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-212980482-1473760632=:3355" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-212980482-1473760632=:3355 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 13 Sep 2016, Namrata A Shettar wrote: > Yes I realize that this may be wrong.Thank you for your inputs! > >  Also,The version of the kernel I am using is : 4.8.0-rc2+ You should be using what you get by doing the following command: git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Maybe this is what you already have? julia > > Thanks, > Namrata > > On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote: > > > On Tue, 13 Sep 2016, Arnd Bergmann wrote: > > > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A > Shettar wrote: > > > --- a/drivers/staging/comedi/comedi_pcmcia.c > > > +++ b/drivers/staging/comedi/comedi_pcmcia.c > > > @@ -18,7 +18,6 @@ > > > > > >  #include > > >  #include > > > - > > >  #include "comedi_pcmcia.h" > > > > > >  /** > > > > > > > I would argue that checkpatch is wrong here, it's very common > to have > > an empty line between the global and the local header files. > > I forwarded this to Joe Perches, and he pointed out that > checkpatch > doesn't give a warning for this.  Namrata, what version of the > kernel are > you using? > > julia > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a- > 49d693bd3c74%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-212980482-1473760632=:3355--