From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761807AbcINMgD (ORCPT ); Wed, 14 Sep 2016 08:36:03 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:45679 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761385AbcINMgB (ORCPT ); Wed, 14 Sep 2016 08:36:01 -0400 X-IronPort-AV: E=Sophos;i="5.30,333,1470693600"; d="scan'208";a="193114523" Date: Wed, 14 Sep 2016 14:35:41 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sandhya Bankar cc: outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Use x instead of x != NULL In-Reply-To: <20160914123349.GA3770@sandhya> Message-ID: References: <20160914123349.GA3770@sandhya> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2016, Sandhya Bankar wrote: > Use x instead of x != NULL . > This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script . > CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit" OK for the patch, but please put a space after the end of each sentence, and don't allow the lines in your commit message to go over 80 characters. julia > > Signed-off-by: Sandhya Bankar > --- > drivers/staging/sm750fb/ddk750_dvi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > index a4a2550..8a39e0e 100644 > --- a/drivers/staging/sm750fb/ddk750_dvi.c > +++ b/drivers/staging/sm750fb/ddk750_dvi.c > @@ -45,7 +45,7 @@ int dviInit( > dvi_ctrl_device_t *pCurrentDviCtrl; > > pCurrentDviCtrl = g_dcftSupportedDviController; > - if (pCurrentDviCtrl->pfnInit != NULL) { > + if (pCurrentDviCtrl->pfnInit) { > return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, > vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, > pllFilterEnable, pllFilterValue); > -- > 1.8.2.3 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914123349.GA3770%40sandhya. > For more options, visit https://groups.google.com/d/optout. >