The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Shrikrishna Khare <skhare@vmware.com>, <pv-drivers@vmware.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<jsavanyo@vmware.com>
Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes
Date: Tue, 28 Nov 2017 13:49:12 -0800	[thread overview]
Message-ID: <alpine.DEB.2.10.1711281341480.24284@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <20171128213327.GJ14512@lunn.ch>



On Tue, 28 Nov 2017, Andrew Lunn wrote:

> >  /*
> >   * Version numbers
> >   */
> > -#define VMXNET3_DRIVER_VERSION_STRING   "1.4.a.0-k"
> > +#define VMXNET3_DRIVER_VERSION_STRING   "1.4.11.0-k"
> >  
> >  /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
> > -#define VMXNET3_DRIVER_VERSION_NUM      0x01040a00
> > +#define VMXNET3_DRIVER_VERSION_NUM      0x01040b00
> 
> Version strings in drivers are totally pointless, but should not this
> be 0x01041100?
> 

Version number is hex value written to vmxnet3 emulation, thus 0x1040b00 
is correct (0x0b = 11). The VERSION_STRING should have previously been 
"1.4.10.0-k", this patch rectifies that by setting correct value 
"1.4.11.0-k".

I will let John Savanyo (cc'ed) comment on having the version in the 
driver part.

Thanks,
Shri

  reply	other threads:[~2017-11-28 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 21:12 [PATCH net-next] vmxnet3: increase default rx ring sizes Shrikrishna Khare
2017-11-28 21:33 ` Andrew Lunn
2017-11-28 21:49   ` Shrikrishna Khare [this message]
2017-11-29 14:14 ` David Miller
     [not found]   ` <CY4PR05MB30610B7258175B4EE661EDD6A53B0@CY4PR05MB3061.namprd05.prod.outlook.com>
2017-11-30 15:11     ` [Pv-drivers] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1711281341480.24284@shri-linux.eng.vmware.com \
    --to=skhare@shri-linux.eng.vmware.com \
    --cc=andrew@lunn.ch \
    --cc=jsavanyo@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=skhare@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox