From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: Colin King <colin.king@canonical.com>
Cc: Shrikrishna Khare <skhare@vmware.com>, <pv-drivers@vmware.com>,
<netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'
Date: Thu, 1 Feb 2018 11:28:52 -0800 [thread overview]
Message-ID: <alpine.DEB.2.10.1802011125140.23969@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <20180201172921.22770-1-colin.king@canonical.com>
On Thu, 1 Feb 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer rq is being initialized but this value is never read, it
> is being updated inside a for-loop. Remove the initialization and
> move it into the scope of the for-loop.
>
> Cleans up clang warning:
> drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored
> to 'rq' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
next prev parent reply other threads:[~2018-02-01 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 17:29 [PATCH] vmxnet3: remove redundant initialization of pointer 'rq' Colin King
2018-02-01 19:28 ` Shrikrishna Khare [this message]
2018-02-01 19:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1802011125140.23969@shri-linux.eng.vmware.com \
--to=skhare@shri-linux.eng.vmware.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox