From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753243AbbGEV3Z (ORCPT <rfc822;w@1wt.eu>);
	Sun, 5 Jul 2015 17:29:25 -0400
Received: from www.linutronix.de ([62.245.132.108]:52389 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753164AbbGEV3S (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 5 Jul 2015 17:29:18 -0400
Date: Sun, 5 Jul 2015 23:28:44 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
cc: Ankit Gupta <ankgupta@codeaurora.org>, mingo@redhat.com,
        agross@codeaurora.org, davem@davemloft.net, rdunlap@infradead.org,
        standby24x7@gmail.com, sboyd@codeaurora.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        gavidov@codeaurora.org, sdharia@codeaurora.org,
        linux-arm-msm@vger.kernel.org, mlocke@codeaurora.org
Subject: Re: [PATCH V3] trace/events: add chip name and hwirq to irq entry
 tracepoint
In-Reply-To: <20150624124227.1cddbbac@gandalf.local.home>
Message-ID: <alpine.DEB.2.11.1507052326100.3916@nanos>
References: <1435162650-32266-1-git-send-email-ankgupta@codeaurora.org> <20150624124227.1cddbbac@gandalf.local.home>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 24 Jun 2015, Steven Rostedt wrote:
> > +
> > +#define show_chip_name(irq)					\
> > +	(irq_get_irq_data(irq)					\
> > +			 ? irq_get_irq_data(irq)->chip->name	\
> > +			 : "NULL")
> > +
> > +#define show_hwirq(irq)						\
> > +	(irq_get_irq_data(irq)					\
> > +			 ? irq_get_irq_data(irq)->hwirq		\
> > +			 : -ENODEV)
> 
> Note these magic functions will only be useful for the tracefs reads of
> the trace files. Userspace tools that extract the data (like perf and
> trace-cmd), will have no idea of how to parse it.
> 
> I'm not against doing this, but I'm just letting you know what the
> effect of this change will be.

What's worse is, that they are racy against a concurrent teardown of
the interrupt. Not a good idea ...

Thanks,

	tglx