From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752624AbbHTUDg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 20 Aug 2015 16:03:36 -0400
Received: from www.linutronix.de ([62.245.132.108]:38217 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752107AbbHTUDf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 20 Aug 2015 16:03:35 -0400
Date: Thu, 20 Aug 2015 22:02:54 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
cc: Borislav Petkov <bp@suse.de>, Dave Hansen <dave.hansen@intel.com>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Chandramouli Narayanan <mouli@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, mouli_7982@yahoo.com
Subject: Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions
 implementations
In-Reply-To: <1440082994.7611.3.camel@schen9-mobl2>
Message-ID: <alpine.DEB.2.11.1508202157260.3873@nanos>
References: <1439844283.21627.5.camel@schen9-desk2.jf.intel.com>  <55D24FEA.1000803@intel.com>  <1439850820.21627.11.camel@schen9-desk2.jf.intel.com>  <alpine.DEB.2.11.1508181846160.3873@nanos>  <1440002998.13451.1.camel@schen9-mobl2>  <20150820040818.GA23184@nazgul.tnic>
 <1440082994.7611.3.camel@schen9-mobl2>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 20 Aug 2015, Tim Chen wrote:
> From: Tim Chen <tim.c.chen@linux.intel.com>
> Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

   sha: is not a proper subsystem name

   x86/cpufeatures: is the correct one

>  Enable cpuid check for Intel SHA extensions implementations

This patch does not enable any checks. It merily adds the feature bit.
 
> The Intel Secure Hash Algorithm Extensions are designed to improve the performance
> of SHA-1 and SHA-256. This patch adds the check for X86_FEATURE_SHA_NI bit.

Again there is no check.

> This will allow the feature to be shown in the /proc/cpuinfo.
> 
> The SHA extension programming guide is found in chapter 8 of the Intel
> Architecture Instruction Set Extensions Programming reference:
> https://software.intel.com/sites/default/files/managed/07/b7/319433-023.pdf
> 
> Originally-by: Chandramouli Narayanan <mouli@linux.intel.com>

So Mouli left the company. What's the point of having his Intel mail
address here and in the Cc list?

Thanks,

	tglx