From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbbJMNts (ORCPT ); Tue, 13 Oct 2015 09:49:48 -0400 Received: from www.linutronix.de ([62.245.132.108]:50096 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbJMNtO (ORCPT ); Tue, 13 Oct 2015 09:49:14 -0400 Date: Tue, 13 Oct 2015 15:48:36 +0200 (CEST) From: Thomas Gleixner To: Qais Yousef cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, jiang.liu@linux.intel.com, ralf@linux-mips.org, linux-mips@linux-mips.org Subject: Re: [RFC v2 PATCH 09/14] MIPS: add support for generic SMP IPI support In-Reply-To: <1444731382-19313-10-git-send-email-qais.yousef@imgtec.com> Message-ID: References: <1444731382-19313-1-git-send-email-qais.yousef@imgtec.com> <1444731382-19313-10-git-send-email-qais.yousef@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015, Qais Yousef wrote: > > +#ifdef CONFIG_GENERIC_IRQ_IPI > +void generic_smp_send_ipi_single(int cpu, unsigned int action) Please use a mips name space. This suggests that it s completely generic, which is not true. > +{ > + generic_smp_send_ipi_mask(cpumask_of(cpu), action); > +} > + > +void generic_smp_send_ipi_mask(const struct cpumask *mask, unsigned int action) Ditto. > +{ > + unsigned long flags; > + unsigned int core; > + int cpu; > + struct ipi_mask ipi_mask; > + > + ipi_mask.cpumask = ((struct cpumask *)mask)->bits; We have accessors for that. Hmm, so for this case we must make the ipi_mask different: struct ipi_mask { unsigned int nbits; bool global; union { struct cpumask *mask; unsigned long cpu_bitmap[]; }; }; Thanks, tglx