The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>, x86-ml <x86@kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Steven Rostedt <rostedt@goodmis.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH -v2.1] x86: Kill notsc
Date: Mon, 16 Nov 2015 22:25:36 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1511162158570.3761@nanos> (raw)
In-Reply-To: <20151116184548.GA20137@pd.tnic>

On Mon, 16 Nov 2015, Borislav Petkov wrote:
> -/*
> - * disable flag for tsc. Takes effect by clearing the TSC cpu flag
> - * in cpu/common.c
> - */
> -int __init notsc_setup(char *str)
> +/* Disable the TSC feature flag to avoid further TSC use. */
> +int __init notsc_setup(void)
>  {
> +#ifndef CONFIG_X86_TSC
>  	setup_clear_cpu_cap(X86_FEATURE_TSC);

This is silly, really.

If CONFIG_X86_TSC is disabled then we should just not compile tsc.c at
all and map cpu_has_tsc and stuff depending on it to false.

Thanks,

	tglx

  reply	other threads:[~2015-11-16 21:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 14:20 [RFC PATCH] x86: Kill notsc Borislav Petkov
2015-10-19  4:47 ` Andy Lutomirski
2015-10-19  8:16   ` Borislav Petkov
2015-10-21 17:58 ` Borislav Petkov
2015-10-21 19:01   ` Peter Zijlstra
2015-10-22 18:51     ` [PATCH -v2] " Borislav Petkov
2015-11-04 10:21       ` Thomas Gleixner
2015-11-04 10:29         ` Borislav Petkov
2015-11-16 18:45           ` [RFC PATCH -v2.1] " Borislav Petkov
2015-11-16 21:25             ` Thomas Gleixner [this message]
2015-11-17  5:02               ` H. Peter Anvin
2015-11-17  8:53                 ` Borislav Petkov
2015-11-17  9:11                   ` Thomas Gleixner
2015-11-17  9:33                     ` Borislav Petkov
2015-11-17 10:08                       ` Thomas Gleixner
2015-11-17 11:09                         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1511162158570.3761@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox