From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143AbcCRJy1 (ORCPT ); Fri, 18 Mar 2016 05:54:27 -0400 Received: from www.linutronix.de ([62.245.132.108]:35963 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcCRJyS (ORCPT ); Fri, 18 Mar 2016 05:54:18 -0400 Date: Fri, 18 Mar 2016 10:52:40 +0100 (CET) From: Thomas Gleixner To: Jacob Pan cc: Srinivas Pandruvada , Borislav Petkov , rjw@rjwysocki.net, linux-pm@vger.kernel.org, mingo@redhat.com, x86@kernel.org, "H. Peter Anvin" , LKML , Peter Zijlstra Subject: Re: [PATCH] powercap: intel_rapl: PSys support In-Reply-To: <20160317185532.7ab0adc5@yairi> Message-ID: References: <1458253409-13318-1-git-send-email-srinivas.pandruvada@linux.intel.com> <20160317225100.GA3805@pd.tnic> <1458255363.3861.40.camel@linux.intel.com> <20160317185532.7ab0adc5@yairi> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Mar 2016, Jacob Pan wrote: > On Thu, 17 Mar 2016 15:56:03 -0700 > Srinivas Pandruvada wrote: > > > > > +#define MSR_PLATFORM_ENERGY_STATUS 0x0000064d > > > > +#define MSR_PLATFORM_POWER_LIMIT 0x0000065c > > > Please add those defines to intel_rapl.c as they're being used only > > > there, apparently. > > OK. I will move them. > > I think it could be used by perf rapl pmu also, but later. Right. And they should be added to perf _BEFORE_ that powercap stuff utilizes them. Thanks, tglx