The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
Cc: Toshi Kani <toshi.kani@hpe.com>,
	mingo@kernel.org, hpa@zytor.com, mcgrof@suse.com,
	jgross@suse.com, paul.gortmaker@windriver.com,
	konrad.wilk@oracle.com, elliott@hpe.com, x86@kernel.org,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR
Date: Tue, 22 Mar 2016 20:17:53 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1603222015510.3978@nanos> (raw)
In-Reply-To: <20160322165725.GB5656@pd.tnic>

On Tue, 22 Mar 2016, Borislav Petkov wrote:
> > +static void pat_keep_handoff_state(void)
> 
> Static function, no need for "pat_" prefix. Also, no need for the
> kernel-doc comment.

I have to disagree. kernel-doc comments are not limited to global
functions.

I realy prefer kernel-doc style for static functions over randomly formatted
ones for consistency reasons.
 
Thanks,

	tglx

      parent reply	other threads:[~2016-03-22 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  0:44 [PATCH 0/6] Enhance PAT init to fix Xorg crashes Toshi Kani
2016-03-17  0:44 ` [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR Toshi Kani
2016-03-22 16:57   ` Borislav Petkov
2016-03-22 18:35     ` Toshi Kani
2016-03-23  8:43       ` Borislav Petkov
2016-03-23 15:46         ` Toshi Kani
2016-03-22 19:17     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1603222015510.3978@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=elliott@hpe.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox