The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Gaurav Jindal (Gaurav Jindal)" <Gaurav.Jindal@spreadtrum.com>
Cc: "Sanjeev Yadav (Sanjeev Kumar Yadav)"
	<Sanjeev.Yadav@spreadtrum.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]time: Optimize nohz idle enter
Date: Tue, 19 Jul 2016 10:47:37 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1607191046220.3596@nanos> (raw)
In-Reply-To: <20160714120416.GB21099@gaurav.jindal@spreadtrum.com>

On Thu, 14 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> 
> tick_nohz_start_idle is called before checking the condition if the idle tick
> can be stopped. In case when can_stop_idle_tick returns 0, the function called
> is of no use thus a extra call doing nothing.
> 
> Shifting calling of function tick_nohz_start_idle inside the if condition makes
> sure that corresponding operations are done only if idle tick can be actually
> stopped. Observance for 1 minute on arm64 architecture shows that shifting code
> can prevent 1.5% of extra calls thus optimizing the idle call sequence.

Nice.

> Signed-off-by: gaurav jindal<gaurav.jindal@spreadtrum.com>
> Signed-off-by: sanjeev yadav<sanjeev.yadav@spreadtrum.com>

This SOB chain is wrong. Sanjeev did not send the patch and is not the
author. Please clarify.

Thanks,

	tglx

       reply	other threads:[~2016-07-19  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160714120416.GB21099@gaurav.jindal@spreadtrum.com>
2016-07-19  8:47 ` Thomas Gleixner [this message]
2016-07-19 10:00   ` [PATCH]time: Optimize nohz idle enter Gaurav Jindal (Gaurav Jindal)
2016-07-19 10:45     ` Thomas Gleixner
2016-07-19 11:51 ` [tip:timers/core] tick/nohz: " tip-bot for Gaurav Jindal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1607191046220.3596@nanos \
    --to=tglx@linutronix.de \
    --cc=Gaurav.Jindal@spreadtrum.com \
    --cc=Sanjeev.Yadav@spreadtrum.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox