From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753074AbcGSKsQ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 06:48:16 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:54990 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752593AbcGSKsN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 06:48:13 -0400
Date: Tue, 19 Jul 2016 12:45:58 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Gaurav Jindal (Gaurav Jindal)" <Gaurav.Jindal@spreadtrum.com>
cc: "Sanjeev Yadav (Sanjeev Kumar Yadav)" <Sanjeev.Yadav@spreadtrum.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]time: Optimize nohz idle enter
In-Reply-To: <20160719095957.GA3691@gauravjindalubtnb.del.spreadtrum.com>
Message-ID: <alpine.DEB.2.11.1607191243230.3596@nanos>
References: <20160714120416.GB21099@gaurav.jindal@spreadtrum.com> <alpine.DEB.2.11.1607191046220.3596@nanos> <20160719095957.GA3691@gauravjindalubtnb.del.spreadtrum.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 19 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> On Tue, Jul 19, 2016 at 10:47:37AM +0200, Thomas Gleixner wrote:
> > On Thu, 14 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> > > 
> > > tick_nohz_start_idle is called before checking the condition if the idle tick
> > > can be stopped. In case when can_stop_idle_tick returns 0, the function called
> > > is of no use thus a extra call doing nothing.
> > > 
> > > Shifting calling of function tick_nohz_start_idle inside the if condition makes
> > > sure that corresponding operations are done only if idle tick can be actually
> > > stopped. Observance for 1 minute on arm64 architecture shows that shifting code
> > > can prevent 1.5% of extra calls thus optimizing the idle call sequence.
> > 
> > Nice.
> > 
> > > Signed-off-by: gaurav jindal<gaurav.jindal@spreadtrum.com>
> > > Signed-off-by: sanjeev yadav<sanjeev.yadav@spreadtrum.com>
> > 
> > This SOB chain is wrong. Sanjeev did not send the patch and is not the
> > author. Please clarify.
> >
> Actually Sanjeev and me worked together, but since only one send the mail so I
> included his name as SOB.

That does not make it more correct. See Documentation/SubmittingPatches. I
fixed it up.

Thanks,

	tglx