The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] posix-timers: make them configurable
Date: Fri, 9 Sep 2016 15:39:24 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609091536510.5679@nanos> (raw)
In-Reply-To: <alpine.LFD.2.20.1609081658570.14769@knanqh.ubzr>

On Thu, 8 Sep 2016, Nicolas Pitre wrote:
> Small embedded systems typically don't need them.  This removes about
> 16KB from the kernel binary size on ARM when configured out.  
> Corresponding syscalls are routed to a stub logging the attempt to
> use those syscalls which should be enough of a clue if they were 
> disabled without proper consideration.
> 
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index ee3de3421f..00e6098e9a 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -6,7 +6,7 @@ menu "PTP clock support"
>  
>  config PTP_1588_CLOCK
>  	tristate "PTP clock support"
> -	depends on NET
> +	depends on NET && POSIX_TIMERS
>  	select PPS
>  	select NET_PTP_CLASSIFY
>  	help

You forgot CONFIG_TIMERFD ....

> +void do_schedule_next_timer(struct siginfo *info)
> +{
> +}

 ....

> +void thread_group_cputimer(struct task_struct *tsk, struct task_cputime *times)
> +{
> +}

You should make them static inlines in the headers so they get compiled out
completely.

Thanks,

	tglx

  parent reply	other threads:[~2016-09-09 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 21:05 [RFC/PATCH] posix-timers: make them configurable Nicolas Pitre
2016-09-08 21:19 ` John Stultz
2016-09-08 21:48   ` Josh Triplett
     [not found]   ` <i7B1bN3EzSJWci7B2bJXya@videotron.ca>
2016-09-08 23:56     ` Nicolas Pitre
2016-09-09  0:37       ` Josh Triplett
2016-09-09  7:48   ` Richard Cochran
2016-09-09  8:00     ` Josh Triplett
2016-09-09 13:47       ` Thomas Gleixner
2016-09-09 13:46     ` Thomas Gleixner
2016-09-09 13:39 ` Thomas Gleixner [this message]
2016-09-13 20:57   ` Nicolas Pitre
2016-09-14  9:47     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609091536510.5679@nanos \
    --to=tglx@linutronix.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox