From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760376AbcINJdr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 05:33:47 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:33546 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760075AbcINJdp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 05:33:45 -0400
Date: Wed, 14 Sep 2016 11:31:17 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
cc: Lee Jones <lee.jones@linaro.org>, "Andrew F. Davis" <afd@ti.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error
In-Reply-To: <20160914084202.1032264-1-arnd@arndb.de>
Message-ID: <alpine.DEB.2.20.1609141129440.6233@nanos>
References: <20160914084202.1032264-1-arnd@arndb.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> Building tps65217 as a loadable module (as done in allmodconfig)
> now fails after we started calling irq_set_parent():
> 
>   ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
> 
> The two obvious workarounds are either to force the driver
> to be built-in, or to make that symbol exported to modules.
> 
> As it's not clear to me if either of them would be acceptable,
> I'm sending both of them here, please comment on which one
> you want to have, or whether the driver should handle this
> differently and not call irq_set_parent() at all.

The question is why it needs to call that. But if it's justified, then I'm
not opposed to export it.

Thanks,

	tglx