From: Thomas Gleixner <tglx@linutronix.de>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-mips@linux-mips.org, linux-remoteproc@vger.kernel.org,
lisa.parratt@imgtec.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] remoteproc/MIPS: Add a remoteproc driver for MIPS
Date: Tue, 20 Sep 2016 11:47:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609201141120.6905@nanos> (raw)
In-Reply-To: <1474361249-31064-6-git-send-email-matt.redfearn@imgtec.com>
On Tue, 20 Sep 2016, Matt Redfearn wrote:
> +/* Intercept CPU hotplug events for syfs purposes */
> +static int mips_rproc_callback(struct notifier_block *nfb, unsigned long action,
> + void *hcpu)
> +{
Please convert to cpu hotplug state machine.
> + unsigned int cpu = (unsigned long)hcpu;
> +
> + switch (action) {
> + case CPU_UP_PREPARE:
> + case CPU_DOWN_FAILED:
> + mips_rproc_device_unregister(cpu);
> + break;
> + case CPU_DOWN_PREPARE:
> + mips_rproc_device_register(cpu);
> + break;
> + }
There is no reason why you need to setup the rproc device on
DOWN_PREPARE. It's sufficient to do that when the CPU is dead, so you can
use a symetric callback prep/dead.
> + /* Dynamically create mips-rproc class devices based on hotplug data */
> + get_online_cpus();
> + for_each_possible_cpu(cpu)
> + if (!cpu_online(cpu))
> + mips_rproc_device_register(cpu);
> + register_hotcpu_notifier(&mips_rproc_notifier);
> + put_online_cpus();
Perhaps we should add support for "reverse" functionality to the state
machine core. I'll have a look later how hard that'd be.
Thanks,
tglx
next prev parent reply other threads:[~2016-09-20 9:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 8:47 [PATCH v2 0/6] MIPS: Remote processor driver Matt Redfearn
2016-09-20 8:47 ` [PATCH v2 1/6] irqchip: mips-gic: Add context saving for MIPS_REMOTEPROC Matt Redfearn
2016-09-20 9:40 ` Thomas Gleixner
2016-09-20 8:47 ` [PATCH v2 2/6] MIPS: tlb-r4k: If there are wired entries, don't use TLBINVF Matt Redfearn
2016-09-22 12:11 ` Ralf Baechle
2016-09-20 8:47 ` [PATCH v2 3/6] MIPS: smp.c: Introduce mechanism for freeing and allocating IPIs Matt Redfearn
2016-09-20 8:47 ` [PATCH v2 4/6] MIPS: CPS: Add VP(E) stealing Matt Redfearn
2016-09-20 8:47 ` [PATCH v2 5/6] remoteproc/MIPS: Add a remoteproc driver for MIPS Matt Redfearn
2016-09-20 9:47 ` Thomas Gleixner [this message]
2016-09-20 15:31 ` Matt Redfearn
2016-10-03 8:35 ` Matt Redfearn
2016-10-03 22:16 ` Bjorn Andersson
2016-10-05 16:22 ` Matt Redfearn
2016-09-20 8:47 ` [PATCH v2 6/6] MIPS: Deprecate VPE Loader Matt Redfearn
2016-09-20 10:25 ` Sergei Shtylyov
2016-09-20 13:19 ` Ralf Baechle
2016-09-20 13:53 ` Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609201141120.6905@nanos \
--to=tglx@linutronix.de \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lisa.parratt@imgtec.com \
--cc=matt.redfearn@imgtec.com \
--cc=ohad@wizery.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox