From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
hmh@hmh.eng.br, bp@alien8.de
Subject: Re: [PATCH] x86: Report Intel platform_id in /proc/cpuinfo
Date: Wed, 21 Sep 2016 14:30:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609211425080.5573@nanos> (raw)
In-Reply-To: <20160602155127.76987-1-andi@firstfloor.org>
On Thu, 2 Jun 2016, Andi Kleen wrote:
Sorry for answering late. This got stuck in my backlog forever.
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index ee81c54..bcd3f59 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -812,6 +812,8 @@ static int collect_cpu_info(int cpu_num, struct cpu_signature *csig)
> /* get processor flags from MSR 0x17 */
> rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]);
> csig->pf = 1 << ((val[1] >> 18) & 7);
> + cpu_data(cpu_num).platform_id = (val[1] >> 18) & 7;
> + cpu_data(cpu_num).has_platform_id = true;
Please move that evaluation to arch/x86/kernel/cpu/intel.c and let the
micro code driver use the information from cpu_data.
Thanks,
tglx
next prev parent reply other threads:[~2016-09-21 12:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 15:51 [PATCH] x86: Report Intel platform_id in /proc/cpuinfo Andi Kleen
2016-06-21 16:05 ` Andi Kleen
2016-06-22 11:54 ` Henrique de Moraes Holschuh
2016-09-21 12:30 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-18 23:23 Andi Kleen
2016-09-23 18:02 Andi Kleen
2016-09-23 0:48 Andi Kleen
2016-09-23 8:12 ` Thomas Gleixner
2016-05-31 21:24 Andi Kleen
2016-06-02 18:27 ` Henrique de Moraes Holschuh
2016-06-02 22:54 ` Andi Kleen
2016-05-05 10:12 Andi Kleen
2016-05-06 12:42 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609211425080.5573@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox