From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752213AbcJDOWg (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Oct 2016 10:22:36 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:36576 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751020AbcJDOWf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Oct 2016 10:22:35 -0400
Date: Tue, 4 Oct 2016 16:19:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiri Olsa <jolsa@redhat.com>
cc: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Len Brown <len.brown@intel.com>, Borislav Petkov <bp@suse.de>,
        Andi Kleen <ak@linux.intel.com>, Juergen Gross <jgross@suse.com>,
        dyoung@redhat.com, Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org
Subject: Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded
 CPUs
In-Reply-To: <20161004122717.GA4998@krava>
Message-ID: <alpine.DEB.2.20.1610041618390.5049@nanos>
References: <1475514432-27682-1-git-send-email-prarit@redhat.com> <alpine.DEB.2.20.1610041241160.7712@nanos> <20161004122717.GA4998@krava>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 4 Oct 2016, Jiri Olsa wrote:
> On Tue, Oct 04, 2016 at 12:58:04PM +0200, Thomas Gleixner wrote:
> > > pmu->boxes[pkg] is garbage because pkg was returned as 0xffff.
> > 
> > And that's what needs to be fixed in the first place.
> 
> right, I'll check on that.. but I think we need this fix as well

That's right.
 
> I was wondering if acpi_boot_init was a better place for that, but then
> Prarit suggested in our discussion that the prefill_possible_map() call
> seems to be a hotplug cleanup.. so it seemed to fit

It's the right place for it.

Thanks,

	tglx