From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756441AbcKKL6e (ORCPT ); Fri, 11 Nov 2016 06:58:34 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40968 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756286AbcKKL6c (ORCPT ); Fri, 11 Nov 2016 06:58:32 -0500 X-IronPort-AV: E=Sophos;i="5.31,621,1473112800"; d="scan'208";a="200050042" Date: Fri, 11 Nov 2016 12:58:27 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Florian Westphal cc: Julia Lawall , pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr Subject: Re: question about xt_find_table_lock In-Reply-To: <20161111112307.GA7274@breakpoint.cc> Message-ID: References: <20161111112307.GA7274@breakpoint.cc> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Nov 2016, Florian Westphal wrote: > Julia Lawall wrote: > > The function xt_find_table_lock defined in net/netfilter/x_tables.c is > > preceeded by a comment that says that it returns ERR_PTR() on error. But > > looking at the definition, I only see occurrences of return NULL and > > returns of pointers that have previously been dereferenced. Is it the > > code or the documentation that is incorrect? The call sites seem to be > > using IS_ERR_OR_NULL. Is there a plan to return ERR_PTR values in the > > future? > > It used to return ERR_PTR, see: > > commit 7926dbfa4bc14e27f4e18a6184a031a1c1e077dc > netfilter: don't use mutex_lock_interruptible() > > So the comment isn't correct anymore and callers could test vs NULL. Thanks for the quick feedback. julia