From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Matthew Whitehead <tedheadster@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Denys Vlasenko <dvlasenk@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/4] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing"
Date: Thu, 1 Dec 2016 11:07:21 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612011107010.3453@nanos> (raw)
In-Reply-To: <20161201090211.nrlyjt5uklcva3pd@pd.tnic>
On Thu, 1 Dec 2016, Borislav Petkov wrote:
> On Thu, Dec 01, 2016 at 06:53:50AM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 30, 2016 at 12:34:53PM -0800, Andy Lutomirski wrote:
> > > This reverts commit ed68d7e9b9cfb64f3045ffbcb108df03c09a0f98.
> > >
> > > The patch wasn't quite correct -- there are non-Intel (and hence
> > > non-486) CPUs that we support that don't have CPUID. Since we no
> > > longer require CPUID for sync_core(), just revert the patch.
> >
> > Might be useful to enumerate which special parts these are.
>
> Right, and since we test for CPUID support at early boot, I think we
> should use the X86_FEATURE_CPUID aspect from what I proposed earlier:
>
> https://lkml.kernel.org/r/20161120111917.pw3alolx4fksfwbv@pd.tnic
Yes, that makes a lot of sense.
Thanks,
tglx
next prev parent reply other threads:[~2016-12-01 10:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 20:34 [PATCH 0/4] CPUID-less CPU fixes and improvements Andy Lutomirski
2016-11-30 20:34 ` [PATCH 1/4] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels Andy Lutomirski
2016-11-30 20:34 ` [PATCH 2/4] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-01 5:53 ` Peter Zijlstra
2016-12-01 9:02 ` Borislav Petkov
2016-12-01 10:07 ` Thomas Gleixner [this message]
2016-12-01 11:15 ` [PATCH] x86/CPU: Add X86_FEATURE_CPUID Borislav Petkov
2016-12-01 17:00 ` Andy Lutomirski
2016-12-02 0:33 ` [PATCH 2/4] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-01 17:00 ` Andy Lutomirski
2016-11-30 20:34 ` [PATCH 3/4] x86/microcode/intel: Replace sync_core() with cpuid_eax(1) Andy Lutomirski
2016-12-01 9:11 ` Borislav Petkov
2016-11-30 20:34 ` [PATCH 4/4] x86/asm: Change sync_core() to use MOV to CR2 to serialize Andy Lutomirski
2016-12-01 9:22 ` Borislav Petkov
2016-12-01 17:08 ` Andy Lutomirski
2016-12-01 17:46 ` Andrew Cooper
2016-12-02 7:34 ` Ingo Molnar
2016-12-02 0:34 ` [PATCH v2 0/6] CPUID-less CPU/sync_core fixes and improvements Andy Lutomirski
2016-12-02 0:34 ` [PATCH v2 1/6] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels Andy Lutomirski
2016-12-02 0:34 ` [PATCH v2 2/6] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-02 0:34 ` [PATCH v2 3/6] x86/microcode/intel: Replace sync_core() with cpuid_eax(1) Andy Lutomirski
2016-12-02 0:35 ` [PATCH v2 4/6] x86/paravirt: Make sync_core() be a paravirt op Andy Lutomirski
2016-12-02 0:35 ` [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation Andy Lutomirski
2016-12-02 11:44 ` Andrew Cooper
2016-12-02 17:07 ` Andy Lutomirski
2016-12-02 17:16 ` Andrew Cooper
2016-12-02 17:23 ` Andy Lutomirski
2016-12-02 17:26 ` Andrew Cooper
2016-12-02 18:50 ` Boris Ostrovsky
2016-12-02 19:34 ` Andy Lutomirski
2016-12-02 20:09 ` Boris Ostrovsky
2016-12-02 17:32 ` Linus Torvalds
2016-12-02 17:38 ` Andy Lutomirski
2016-12-02 17:53 ` Linus Torvalds
2016-12-02 18:03 ` Borislav Petkov
2016-12-02 18:27 ` Linus Torvalds
2016-12-02 18:50 ` Borislav Petkov
2016-12-02 19:03 ` Linus Torvalds
2016-12-02 19:20 ` Borislav Petkov
2016-12-02 19:24 ` Linus Torvalds
2016-12-02 19:28 ` Borislav Petkov
2016-12-03 15:02 ` [PATCH] x86/alternatives: Do not use sync_core() to serialize I$ Borislav Petkov
2016-12-03 17:05 ` Andy Lutomirski
2016-12-20 7:58 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2016-12-20 9:35 ` tip-bot for Borislav Petkov
2016-12-02 19:30 ` [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation Andy Lutomirski
2016-12-02 19:35 ` Linus Torvalds
2016-12-02 20:41 ` Andy Lutomirski
2016-12-02 21:10 ` Linus Torvalds
2016-12-02 22:55 ` Andy Lutomirski
2016-12-02 23:09 ` Linus Torvalds
2016-12-02 19:23 ` Andy Lutomirski
2016-12-02 19:30 ` Borislav Petkov
2016-12-03 12:44 ` Borislav Petkov
2016-12-02 0:35 ` [PATCH v2 6/6] x86/asm: Change sync_core() to use MOV to CR2 to serialize Andy Lutomirski
2016-12-02 0:36 ` [PATCH 0/4] CPUID-less CPU fixes and improvements Andy Lutomirski
2016-12-02 10:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612011107010.3453@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tedheadster@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox