From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940743AbdAJS3u (ORCPT ); Tue, 10 Jan 2017 13:29:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:53541 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756823AbdAJS2m (ORCPT ); Tue, 10 Jan 2017 13:28:42 -0500 X-IronPort-AV: E=Sophos;i="5.33,344,1477954800"; d="scan'208";a="208669386" Date: Tue, 10 Jan 2017 19:28:39 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Kees Cook cc: cocci@systeme.lip6.fr, Pengfei Wang , Vaishali Thakkar , linux-kernel@vger.kernel.org Subject: Re: [RFC] coccicheck: add a test for repeat memory fetches In-Reply-To: <20170109231323.GA89642@beast> Message-ID: References: <20170109231323.GA89642@beast> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2302 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2342 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2365 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2406 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2439 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2491 Do you want the above results? They have the form: if (copy_from_user(&t, useraddr, sizeof(t))) My reasoning was that there could be no problem here, because the size is the size of the destination structure. It doesn't depend on user level data. julia