From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdARKra (ORCPT ); Wed, 18 Jan 2017 05:47:30 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:49143 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbdARKr2 (ORCPT ); Wed, 18 Jan 2017 05:47:28 -0500 Date: Wed, 18 Jan 2017 11:46:46 +0100 (CET) From: Thomas Gleixner To: Ruslan Ruslichenko cc: Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, xe-linux-external@cisco.com Subject: Re: [PATCH] x86/ioapic: add IO-APIC irq_chip retrigger hook In-Reply-To: <1484662432-13580-1-git-send-email-rruslich@cisco.com> Message-ID: References: <1484662432-13580-1-git-send-email-rruslich@cisco.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2017, Ruslan Ruslichenko wrote: > After commit d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical > irqdomain interfaces") IO-APIC is switched to hierarchical irqdomain > implementation. Also this patch removed irq_retrigger hook for IO-APIC > chip which seem to be wrong. Without this hook some edge-triggered irq's > might be lost, since kernel uses it to retrigger edge irq's triggered > while they are being handled or disabled by driver Restoring the callbacks is the right thing to do, but there is no problem because if the retrigger callback is empty then pending edge interrupts are resent by software. It's just less efficient, but not a issue. Thanks, tglx