From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109AbdBKJXV (ORCPT ); Sat, 11 Feb 2017 04:23:21 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:34985 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbdBKJXT (ORCPT ); Sat, 11 Feb 2017 04:23:19 -0500 Date: Sat, 11 Feb 2017 10:23:16 +0100 (CET) From: Thomas Gleixner To: John Stultz cc: Jess Frazelle , Rik van Riel , open list , kernel-hardening@lists.openwall.com Subject: Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init In-Reply-To: Message-ID: References: <20170211013758.3288-1-me@jessfraz.com> <20170211013758.3288-2-me@jessfraz.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2017, John Stultz wrote: > On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle wrote: > > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was > > called only during init. Most of the caller functions were already annotated as > > __init. > > unregister_syscore_ops() was never called on these ops. > > This protects the data structure from accidental corruption. > > > > Suggested-by: Kees Cook > > Signed-off-by: Jess Frazelle > > Acked-by: Rik van Riel > > Thanks for sending this out. Looks reasonable to me. I'll queue it for > testing, targeting for 4.12. NAK. See: http://lkml.kernel.org/r/alpine.DEB.2.20.1702110948030.3734@nanos Thanks, tglx