From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbdBRTqy (ORCPT ); Sat, 18 Feb 2017 14:46:54 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:45045 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461AbdBRTqx (ORCPT ); Sat, 18 Feb 2017 14:46:53 -0500 X-IronPort-AV: E=Sophos;i="5.35,174,1484002800"; d="scan'208";a="261107404" Date: Sat, 18 Feb 2017 20:46:50 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: simran singhal , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses In-Reply-To: <1487445694.2198.26.camel@perches.com> Message-ID: References: <20170218183648.GA2680@singhal-Inspiron-5558> <1487445694.2198.26.camel@perches.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c > [] > > > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) > > > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; > > > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; > > > > > > - memset((void *)(&(pHTInfo->SelfHTCap)), 0, > > > + memset((void *)(&pHTInfo->SelfHTCap), 0, > > > > You don't need the parens around the argument of the cast either. > > Nor need the cast at all. > > memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap)); > > etc... Indeed. Thanks! julia