From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbdB1BDg (ORCPT ); Mon, 27 Feb 2017 20:03:36 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:25471 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdB1BD3 (ORCPT ); Mon, 27 Feb 2017 20:03:29 -0500 X-IronPort-AV: E=Sophos;i="5.35,215,1484002800"; d="scan'208";a="262317885" Date: Mon, 27 Feb 2017 22:19:51 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 3/5] staging: rtl8712: Remove unnecessary else after return In-Reply-To: <1488219268-3006-3-git-send-email-singhalsimran0@gmail.com> Message-ID: References: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com> <1488219268-3006-3-git-send-email-singhalsimran0@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 One might be surprised that the following code was detected using the above semantic patch, because in the code below there is no return in the if branches. Actually, as a special feature, when one has an if branch that ends in return, Coccinelle will skip through any gotos and see if the return is matched afterward. Indeed it is a common pattern to have if (...) { foo(x); bar(y); return -ENOMEM; } But the code can also be cut up as eg if (...) { ret = -ENOMEM; goto out; } ... out: foo(x); bar(y); return ret; To avoid having to write multiple patterns for these cases, Coccinelle will just jump through the return in the second case, allowing the same pattern to match both of them. julia > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8712/os_intfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c > index 8836b31..3062167 100644 > --- a/drivers/staging/rtl8712/os_intfs.c > +++ b/drivers/staging/rtl8712/os_intfs.c > @@ -411,8 +411,7 @@ static int netdev_open(struct net_device *pnetdev) > goto netdev_open_error; > if (!padapter->dvobjpriv.inirp_init) > goto netdev_open_error; > - else > - padapter->dvobjpriv.inirp_init(padapter); > + padapter->dvobjpriv.inirp_init(padapter); > r8712_set_ps_mode(padapter, padapter->registrypriv.power_mgnt, > padapter->registrypriv.smart_ps); > } > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488219268-3006-3-git-send-email-singhalsimran0%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >