From: Julia Lawall <julia.lawall@lip6.fr>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: w.d.hubbs@gmail.com, Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: speakup: Alignment match open parenthesis
Date: Thu, 2 Mar 2017 11:32:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703021131220.3414@hadrien> (raw)
In-Reply-To: <20170302021841.GA1812@arushi-HP-Pavilion-Notebook>
On Thu, 2 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/speakup/i18n.c | 2 +-
> drivers/staging/speakup/kobjects.c | 38 +++++++++++++++++++-------------------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index 11f1418b4006..ac1ebead3c3f 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -607,7 +607,7 @@ void spk_reset_msg_group(struct msg_group_t *group)
> void spk_initialize_msgs(void)
> {
> memcpy(speakup_msgs, speakup_default_msgs,
> - sizeof(speakup_default_msgs));
> + sizeof(speakup_default_msgs));
> }
>
> /* Free user-supplied strings when module is unloaded: */
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index fdd6e4b33951..61656c7c2dc9 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -79,7 +79,7 @@ static ssize_t chars_chartab_show(struct kobject *kobj,
> * character descriptions or chartab entries.
> */
> static void report_char_chartab_status(int reset, int received, int used,
> - int rejected, int do_characters)
> + int rejected, int do_characters)
> {
> static char const *object_type[] = {
> "character class entries",
> @@ -92,7 +92,7 @@ static void report_char_chartab_status(int reset, int received, int used,
> pr_info("%s reset to defaults\n", object_type[do_characters]);
> } else if (received) {
> len = snprintf(buf, sizeof(buf),
> - " updated %d of %d %s\n",
> + " updated %d of %d %s\n",
> used, received, object_type[do_characters]);
This line should be lined up too.
julia
prev parent reply other threads:[~2017-03-02 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 2:18 [PATCH] staging: speakup: Alignment match open parenthesis Arushi Singhal
2017-03-02 10:32 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703021131220.3414@hadrien \
--to=julia.lawall@lip6.fr \
--cc=arushisinghal19971997@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox