From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751478AbdCBWBx (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 17:01:53 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:52717
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751291AbdCBWBv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 17:01:51 -0500
X-IronPort-AV: E=Sophos;i="5.35,233,1484002800"; 
   d="scan'208";a="215374171"
Date: Thu, 2 Mar 2017 22:56:00 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: simran singhal <singhalsimran0@gmail.com>
cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de,
        outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary
 cast on void pointer
In-Reply-To: <1488489544-25941-5-git-send-email-singhalsimran0@gmail.com>
Message-ID: <alpine.DEB.2.20.1703022254450.2175@hadrien>
References: <1488489544-25941-1-git-send-email-singhalsimran0@gmail.com> <1488489544-25941-5-git-send-email-singhalsimran0@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext)
>  {
>  	unsigned long irql;
>  	struct recv_reorder_ctrl *preorder_ctrl =
> -				 (struct recv_reorder_ctrl *)pcontext;
> +				 pcontext;

Coccinelle doesn't always generate code in the best way.  pcontext can be
moved up to the previous line in this case.

julia