From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751841AbdCCI5z (ORCPT ); Fri, 3 Mar 2017 03:57:55 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:10542 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdCCI5v (ORCPT ); Fri, 3 Mar 2017 03:57:51 -0500 X-IronPort-AV: E=Sophos;i="5.35,236,1484002800"; d="scan'208";a="215412569" Date: Fri, 3 Mar 2017 09:41:07 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2 4/5] staging: rts5208: Remove unnecessary cast on void pointer In-Reply-To: <20170303083130.GA25123@singhal-Inspiron-5558> Message-ID: References: <20170303083130.GA25123@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When you send a v2 for a patch in a series, you need to send a v2 for all of the patches in the series. julia On Fri, 3 Mar 2017, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > - (T*) > e > ) > > Signed-off-by: simran singhal > --- > > v2: > -Moved buf to the previous line. > > drivers/staging/rts5208/rtsx_transport.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c > index 2379901..8b57e17 100644 > --- a/drivers/staging/rts5208/rtsx_transport.c > +++ b/drivers/staging/rts5208/rtsx_transport.c > @@ -766,8 +766,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip, u8 card, void *buf, size_t len, > return -EIO; > > if (use_sg) { > - err = rtsx_transfer_sglist_adma(chip, card, > - (struct scatterlist *)buf, > + err = rtsx_transfer_sglist_adma(chip, card, buf, > use_sg, dma_dir, timeout); > } else { > err = rtsx_transfer_buf(chip, card, buf, len, dma_dir, timeout); > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170303083130.GA25123%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >