From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933587AbdCJSYA (ORCPT ); Fri, 10 Mar 2017 13:24:00 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26126 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933138AbdCJSXq (ORCPT ); Fri, 10 Mar 2017 13:23:46 -0500 X-IronPort-AV: E=Sophos;i="5.36,142,1486422000"; d="scan'208";a="216340402" Date: Fri, 10 Mar 2017 19:23:26 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: outreachy-kernel , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: speakup: Avoid multiple assignments on same line In-Reply-To: <3f1d5d12-ab81-46ae-84a7-9dd421baec05@googlegroups.com> Message-ID: References: <20170310171337.GA4940@arushi-HP-Pavilion-Notebook> <3f1d5d12-ab81-46ae-84a7-9dd421baec05@googlegroups.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-549073779-1489170206=:3356" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8323329-549073779-1489170206=:3356 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 10 Mar 2017, Arushi Singhal wrote: > Should I resend the patch Maybe let it go. If Greg asked for a resend, he's probably fine with it as is. It's more me who would rather know whether it is something I have seen before :) julia > > On Friday, March 10, 2017 at 10:50:28 PM UTC+5:30, Julia Lawall wrote: > > > On Fri, 10 Mar 2017, Arushi Singhal wrote: > > > This patch fixes the checkpatch.pl warning "multiple > assignments > > should be avoided." > > Is this something that you have sent before that Greg asked you > to resend? > It could be good to put RESEND in [PATCH] in that case. > > julia > > > > > Signed-off-by: Arushi Singhal > > --- > >  drivers/staging/speakup/main.c | 18 ++++++++++++------ > >  1 file changed, 12 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/speakup/main.c > b/drivers/staging/speakup/main.c > > index c1c3ee7dc95a..6c21ae1ae2d3 100644 > > --- a/drivers/staging/speakup/main.c > > +++ b/drivers/staging/speakup/main.c > > @@ -269,9 +269,12 @@ static unsigned char > get_attributes(struct vc_data *vc, u16 *pos) > > > >  static void speakup_date(struct vc_data *vc) > >  { > > -        spk_x = spk_cx = vc->vc_x; > > -        spk_y = spk_cy = vc->vc_y; > > -        spk_pos = spk_cp = vc->vc_pos; > > +        spk_x = vc->vc_x; > > +        spk_cx = spk_x; > > +        spk_y = vc->vc_y; > > +        spk_cy = spk_y; > > +        spk_pos = vc->vc_pos; > > +        spk_cp = spk_pos; > >          spk_old_attr = spk_attr; > >          spk_attr = get_attributes(vc, (u_short *)spk_pos); > >  } > > @@ -1643,9 +1646,12 @@ static int speak_highlight(struct > vc_data *vc) > >                  spk_do_flush(); > > >                  spkup_write(speakup_console[vc_num]->ht.highbuf[hc], > >                             >  speakup_console[vc_num]->ht.highsize[hc]); > > -                spk_pos = spk_cp = > speakup_console[vc_num]->ht.rpos[hc]; > > -                spk_x = spk_cx = > speakup_console[vc_num]->ht.rx[hc]; > > -                spk_y = spk_cy = > speakup_console[vc_num]->ht.ry[hc]; > > +                spk_pos = > speakup_console[vc_num]->ht.rpos[hc]; > > +                spk_cp = > speakup_console[vc_num]->ht.rpos[hc]; > > +                spk_x = speakup_console[vc_num]->ht.rx[hc]; > > +                spk_cx = speakup_console[vc_num]->ht.rx[hc]; > > +                spk_y = speakup_console[vc_num]->ht.ry[hc]; > > +                spk_cy = speakup_console[vc_num]->ht.ry[hc]; > >                  return 1; > >          } > >          return 0; > > -- > > 2.11.0 > > > > -- > > You received this message because you are subscribed to the > Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from > it, send an email to outreachy-kern...@googlegroups.com. > > To post to this group, send email to > outreach...@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170310171337.GA4940%40 > arushi-HP-Pavilion-Notebook. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/3f1d5d12-ab81-46ae-84a7- > 9dd421baec05%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-549073779-1489170206=:3356--