From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751927AbdFTOGl (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 10:06:41 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:44108 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751025AbdFTOGj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 10:06:39 -0400
Date: Tue, 20 Jun 2017 16:05:07 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
cc: linux-kernel@vger.kernel.org, vincent.guittot@linaro.org,
        peterz@infradead.org, rafael@kernel.org, nicolas.pitre@linaro.org,
        Mark Rutland <mark.rutland@arm.com>,
        Vineet Gupta <vgupta@synopsys.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Richard Cochran <rcochran@linutronix.de>,
        Ray Jui <ray.jui@broadcom.com>, Christoph Hellwig <hch@lst.de>,
        Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
        "open list:SYNOPSYS ARC ARCH..." <linux-snps-arc@lists.infradead.org>,
        "moderated list:ARM/SAMSUNG EXYNO..." 
        <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH V10 1/3] irq: Allow to pass the IRQF_TIMER flag with
 percpu irq request
In-Reply-To: <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org>
Message-ID: <alpine.DEB.2.20.1706201520290.1869@nanos>
References: <20170612135108.GD2261@mai> <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 12 Jun 2017, Daniel Lezcano wrote:
> But, the API request_percpu_irq does not allow to pass a flag, hence specifying
> if the interrupt type is a timer.
> 
> Add a function request_percpu_irq_flags() where we can specify the flags. The
> request_percpu_irq() function is changed to be a wrapper to
> request_percpu_irq_flags() passing a zero flag parameter.

And exactly this change wants to be a separate patch. We do not make whole
sale changes this way. You should know that already and someone pointed
that out to you in some of the earlier versions.

> -int request_percpu_irq(unsigned int irq, irq_handler_t handler,
> -		       const char *devname, void __percpu *dev_id)
> +int request_percpu_irq_flags(unsigned int irq, irq_handler_t handler,

The function name sucks. The first time I read it, it meant request the per
cpu irq flags, which is not what you aim at, right?

Please make that __request_percpu_irq() for now and on -rc1 time provide a
patch set to convert all current request_percpu_irq() users to have the
extra argument and then remove the __request_percpu_irq() intermediate.

Thanks,

	tglx