From: Thomas Gleixner <tglx@linutronix.de>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered
Date: Fri, 1 Sep 2017 09:44:56 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709010944490.1857@nanos> (raw)
In-Reply-To: <20170901042956.29594-1-npiggin@gmail.com>
On Fri, 1 Sep 2017, Nicholas Piggin wrote:
> When failing to enter broadcast timer mode for an idle state that
> requires it, a new state is selected that does not require broadcast,
> but the broadcast variable remains set. This causes
> tick_broadcast_exit to be called despite not having entered broadcast
> mode.
>
> This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some
> cases. It does not appear to cause problems for code today, but seems
> to violate the interface so should be fixed.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> drivers/cpuidle/cpuidle.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 60bb64f4329d..4453e27f855e 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -208,6 +208,7 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
> return -EBUSY;
> }
> target_state = &drv->states[index];
> + broadcast = false;
> }
>
> /* Take note of the planned idle state. */
> --
> 2.13.3
>
>
next prev parent reply other threads:[~2017-09-01 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 4:29 [PATCH] cpuidle: fix broadcast control when broadcast can not be entered Nicholas Piggin
2017-09-01 7:44 ` Thomas Gleixner [this message]
2017-10-03 0:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709010944490.1857@nanos \
--to=tglx@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox