From: Julia Lawall <julia.lawall@lip6.fr>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!='
Date: Sun, 10 Sep 2017 22:01:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709102201030.6548@hadrien> (raw)
In-Reply-To: <be22d7c63780098571fec9d490b1a83039ddbb75.1505052882.git.harshasharmaiitr@gmail.com>
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use spaces around most binary operators
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 18f0ac2..5ceccd7 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -1140,7 +1140,7 @@ static int pm_netdev_open(struct net_device *pnetdev, u8 bnormal)
> }
> }
> else
> - status = (_SUCCESS == ips_netdrv_open(padapter))?(0):(-1);
> + status = (_SUCCESS == ips_netdrv_open(padapter)) ? (0) : (-1);
>
> return status;
> }
> @@ -1262,7 +1262,7 @@ void rtw_dev_unload(struct adapter *padapter)
> rtw_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req);
> #ifdef CONFIG_WOWLAN
> if (pwrctl->bSupportRemoteWakeup == true &&
> - pwrctl->wowlan_mode ==true) {
> + pwrctl->wowlan_mode == true) {
> DBG_871X_LEVEL(_drv_always_, "%s bSupportRemoteWakeup ==true do not run rtw_hal_deinit()\n", __func__);
> }
> else
> @@ -1524,7 +1524,7 @@ int rtw_suspend_common(struct adapter *padapter)
> while (pwrpriv->bips_processing == true)
> msleep(1);
>
> - if ((!padapter->bup) || (padapter->bDriverStopped)||(padapter->bSurpriseRemoved))
> + if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved))
> {
> DBG_871X("%s bup =%d bDriverStopped =%d bSurpriseRemoved = %d\n", __func__
> , padapter->bup, padapter->bDriverStopped, padapter->bSurpriseRemoved);
> @@ -1671,7 +1671,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
> DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);
> }
>
> - if (padapter->pid[1]!= 0) {
> + if (padapter->pid[1] != 0) {
> DBG_871X("pid[1]:%d\n", padapter->pid[1]);
> rtw_signal_process(padapter->pid[1], SIGUSR2);
> }
> @@ -1774,7 +1774,7 @@ int rtw_resume_process_ap_wow(struct adapter *padapter)
> rtw_netif_wake_queue(pnetdev);
> }
>
> - if (padapter->pid[1]!= 0) {
> + if (padapter->pid[1] != 0) {
> DBG_871X("pid[1]:%d\n", padapter->pid[1]);
> rtw_signal_process(padapter->pid[1], SIGUSR2);
> }
> @@ -1842,7 +1842,7 @@ static int rtw_resume_process_normal(struct adapter *padapter)
> netif_device_attach(pnetdev);
> netif_carrier_on(pnetdev);
>
> - if (padapter->pid[1]!= 0) {
> + if (padapter->pid[1] != 0) {
> DBG_871X("pid[1]:%d\n", padapter->pid[1]);
> rtw_signal_process(padapter->pid[1], SIGUSR2);
> }
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/be22d7c63780098571fec9d490b1a83039ddbb75.1505052882.git.harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-10 20:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 15:10 [PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style Harsha Sharma
2017-09-10 15:15 ` [PATCH 01/10] staging: rtl8723bs: Add spaces around '=' Harsha Sharma
2017-09-10 19:44 ` [Outreachy kernel] " Julia Lawall
2017-09-10 15:17 ` [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*' Harsha Sharma
2017-09-10 19:36 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:21 ` [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!=' Harsha Sharma
2017-09-10 20:01 ` Julia Lawall [this message]
2017-09-10 17:23 ` [PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line Harsha Sharma
2017-09-10 20:33 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:29 ` [PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings Harsha Sharma
2017-09-11 11:09 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:32 ` [PATCH 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-11 11:13 ` [Outreachy kernel] " Julia Lawall
2017-09-11 16:44 ` Greg KH
2017-09-10 17:34 ` [PATCH 07/10] staging: rtl8723bs: Removed unneccesary space Harsha Sharma
2017-09-11 16:46 ` Greg KH
2017-09-10 17:36 ` [PATCH 08/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-10 17:39 ` [PATCH 09/10] staging: rtl8723bs: Remove unneccesary braces and change position of open brace Harsha Sharma
2017-09-10 20:18 ` [PATCH] spelling.txt: Add "unnecessary" typo variants Joe Perches
2017-09-10 17:41 ` [PATCH 10/10] staging: rtl8723bs: Remove unnecessary blank lines Harsha Sharma
2017-09-12 10:08 ` [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space Harsha Sharma
2017-09-12 10:22 ` [Outreachy kernel] " Julia Lawall
2017-09-12 10:33 ` [PATCH v3 07/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-12 13:35 ` [PATCH v2 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-12 20:41 ` Greg KH
2017-10-08 12:44 ` Harsha Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709102201030.6548@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox