From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdIVRJn (ORCPT ); Fri, 22 Sep 2017 13:09:43 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34432 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbdIVRJm (ORCPT ); Fri, 22 Sep 2017 13:09:42 -0400 X-IronPort-AV: E=Sophos;i="5.42,427,1500933600"; d="scan'208";a="292341887" Date: Fri, 22 Sep 2017 19:09:04 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] [media] spca500: Use common error handling code in spca500_synch310() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 22 Sep 2017 18:45:07 +0200 > > Adjust a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/media/usb/gspca/spca500.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/usb/gspca/spca500.c b/drivers/media/usb/gspca/spca500.c > index da2d9027914c..1f224f5e5b19 100644 > --- a/drivers/media/usb/gspca/spca500.c > +++ b/drivers/media/usb/gspca/spca500.c > @@ -501,7 +501,6 @@ static int spca500_full_reset(struct gspca_dev *gspca_dev) > static int spca500_synch310(struct gspca_dev *gspca_dev) > { > - if (usb_set_interface(gspca_dev->dev, gspca_dev->iface, 0) < 0) { > - PERR("Set packet size: set interface error"); > - goto error; > - } > + if (usb_set_interface(gspca_dev->dev, gspca_dev->iface, 0) < 0) > + goto report_failure; > + > spca500_ping310(gspca_dev); > @@ -514,12 +513,12 @@ static int spca500_synch310(struct gspca_dev *gspca_dev) > /* Windoze use pipe with altsetting 6 why 7 here */ > - if (usb_set_interface(gspca_dev->dev, > - gspca_dev->iface, > - gspca_dev->alt) < 0) { > - PERR("Set packet size: set interface error"); > - goto error; > - } > + if (usb_set_interface(gspca_dev->dev, gspca_dev->iface, gspca_dev->alt) > + < 0) > + goto report_failure; > + > return 0; > -error: > + > +report_failure: > + PERR("Set packet size: set interface error"); > return -EBUSY; > } Why change the label name? They are both equally uninformative. julia