From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751199AbdJBLsd (ORCPT ); Mon, 2 Oct 2017 07:48:33 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34701 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdJBLsc (ORCPT ); Mon, 2 Oct 2017 07:48:32 -0400 X-IronPort-AV: E=Sophos;i="5.42,469,1500933600"; d="scan'208";a="293723710" Date: Mon, 2 Oct 2017 13:48:29 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Keerthi Reddy cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [Outreachy kernel] [PATCH] staging: rts5208: use usleep_range instead of udelay In-Reply-To: <20171002114322.GA8908@manoharreddy> Message-ID: References: <20171002114322.GA8908@manoharreddy> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Oct 2017, Keerthi Reddy wrote: > Since a its a slow device, allow a small range of 100 How do you know that it is a slow device? Try to make the commit log message more self contained, not a continuation of the subject line, and use the imperative. julia > > Signed-off-by: Keerthi Reddy > --- > drivers/staging/rts5208/rtsx_card.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c > index a6b7bff..418e29d 100644 > --- a/drivers/staging/rts5208/rtsx_card.c > +++ b/drivers/staging/rts5208/rtsx_card.c > @@ -825,7 +825,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk) > } > > if (sd_vpclk_phase_reset) { > - udelay(200); > + usleep_range(200, 300); > retval = rtsx_write_register(chip, SD_VPCLK0_CTL, > PHASE_NOT_RESET, PHASE_NOT_RESET); > if (retval) { > @@ -838,7 +838,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk) > rtsx_trace(chip); > return retval; > } > - udelay(200); > + usleep_range(200, 300); > } > retval = rtsx_write_register(chip, CLK_CTL, 0xFF, 0); > if (retval) { > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171002114322.GA8908%40manoharreddy. > For more options, visit https://groups.google.com/d/optout. >