From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbdJRSbt (ORCPT ); Wed, 18 Oct 2017 14:31:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58318 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdJRSbq (ORCPT ); Wed, 18 Oct 2017 14:31:46 -0400 Date: Wed, 18 Oct 2017 20:31:27 +0200 (CEST) From: Thomas Gleixner To: Benjamin Gaignard cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, daniel.lezcano@linaro.org, ludovic.barre@st.com, julien.thierry@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/5] clocksource: stm32: convert driver to timer_of In-Reply-To: <1508331506-23782-3-git-send-email-benjamin.gaignard@linaro.org> Message-ID: References: <1508331506-23782-1-git-send-email-benjamin.gaignard@linaro.org> <1508331506-23782-3-git-send-email-benjamin.gaignard@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Oct 2017, Benjamin Gaignard wrote: > Convert driver to use timer_of helpers. This allow to remove > custom proprietary structure. > > Increase min delta value because if it is too small it could > generate too much interrupts and the system will not be able > to catch them all. This does two completely independent changes at once. What the heck has increasing min delta to do with converting it to timer_of() helpers? Nothing at all. So please split this into two distinct patches. Each doing ONE thing. See Documentation/process/submitting-patches.rst: 3) Separate your changes ------------------------ Separate each **logical change** into a separate patch. Reading, understanding and complying with that document is not optional. Thanks, tglx