From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752739AbdJSN3j (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 09:29:39 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:33438 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751501AbdJSN3i (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 09:29:38 -0400
Date: Thu, 19 Oct 2017 15:29:28 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Matt Redfearn <matt.redfearn@mips.com>
cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
        James Hogan <james.hogan@mips.com>, linux-mips@linux-mips.org,
        James Hogan <jhogan@kernel.org>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clockevents: Retry programming min delta up to 10
 times
In-Reply-To: <5b782526-b130-77f2-6d9a-15839e12e065@mips.com>
Message-ID: <alpine.DEB.2.20.1710191527570.1971@nanos>
References: <1508414135-29123-1-git-send-email-matt.redfearn@mips.com> <alpine.DEB.2.20.1710191435280.1971@nanos> <5b782526-b130-77f2-6d9a-15839e12e065@mips.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 19 Oct 2017, Matt Redfearn wrote:
> On 19/10/17 13:43, Thomas Gleixner wrote:
> > 	delta = 0;
> > 	for (i = 0; i < 10; i++) {
> > 		delta += dev->min_delta_ns;
> > 		dev->next_event = ktime_add_ns(ktime_get(), delta);
> > 		clc = .....
> > 	   	.....
> > 
> > That makes it more likely to succeed fast. Hmm?
> 
> That will set the target time to increasing multiples of min_delta_ns in the
> future, right?

Yes, but without fiddling with min_delta_ns itself.

> Sure, it should make it succeed faster - I'll make it like
> that. Are you OK with the arbitrarily chosen 10 retries?

I lost my crystalball so I have to trust yours :)

Thanks,

	tglx